After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744250 - libnm: do not use deprecated Gtk-Doc tags for GObject introspection
libnm: do not use deprecated Gtk-Doc tags for GObject introspection
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-10 11:36 UTC by Jiri Klimes
Modified: 2018-03-26 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[patch] fix deprecated annotations (10.23 KB, patch)
2015-02-17 09:22 UTC, Jiri Klimes 		none Details | Review

Description Jiri Klimes 2015-02-10 11:36:18 UTC 
Top level Gtk-Doc tags are deprecated. Use identifier specific annotations instead.

https://mail.gnome.org/archives/commits-list/2013-October/msg03220.html
https://wiki.gnome.org/action/show/Projects/GObjectIntrospection/Annotations
Comment 1 Jiri Klimes 2015-02-10 11:38:17 UTC 
See branch jk/libnm-annotation-fix
Comment 2 Dan Winship 2015-02-10 21:40:58 UTC 
I tried this at one point, but the problem is that older versions of gobject-introspection will error out if they see the new-style annotations. So we can't switch to the new style until we no longer support the old g-i. (IIRC, GNOME 3.10 vs GNOME 3.12 is when the switch happened. Not sure of the corresponding gobject-introspection versions.)

Possibly the best fix is to get g-i to add an option to not warn... (Actually, we could just disable g-i warnings entirely in normal builds, and add a note to the release process wiki page reminding you to re-enable them and read through them before releasing a new tarball.)
Comment 3 Jiri Klimes 2015-02-11 07:39:50 UTC 
Hmm, according to [1] the new annotations are in place for quite some time.
"virtual" since v0.6.3
"type" since v0.6.2

When I check e.g. koji for Fedora builds, even Fedora 13 from 2009 has 0.6.7
(gobject-introspection-0.6.7-1.fc13	mclasen	2009-12-22)

[1] https://wiki.gnome.org/action/show/Projects/GObjectIntrospection/Annotations
Comment 4 Dan Winship 2015-02-11 13:40:40 UTC 
It's not the specific tags, it's the syntax; older gobject-introspection will error out if you use those tags in the header line with g-i syntax, rather than at the bottom with gtk-doc syntax. (At least, it did when I tried...)
Comment 5 Jiri Klimes 2015-02-12 14:24:27 UTC 
Ok, I tried Fedora 18 and it doesn't parse the new syntax. So I dug further and found the commit [1] and a bug where the discussion took place [2].

The commit is from 2013-07-25 and it is in gi from v1.39. Unfortunately, v1.39 is only present in Fedora 21.

[1] https://git.gnome.org/browse/gobject-introspection/commit/?id=b6954536f32352c0c29fe5a9a73de1018559a9c5
[2] https://bugzilla.gnome.org/show_bug.cgi?id=676133
Comment 6 Thomas Haller 2015-02-16 18:23:26 UTC 
seems like this is on hold until we bump the requirements.

Let's attach the patches to this BZ (for later reference) and unblock nm-review/nm-patch.
Comment 7 Jiri Klimes 2015-02-17 09:22:05 UTC 
Created attachment 296995 [details] [review]
[patch] fix deprecated annotations

Attaching the patches from jk/libnm-annotation-fix.