After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744241 - [review] config: add configure and quit command line option
[review] config: add configure and quit command line option
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-10 10:56 UTC by Lubomir Rintel
Modified: 2015-02-16 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
config: add configure and quit command line option (2.93 KB, text/plain)
2015-02-10 10:56 UTC, Lubomir Rintel 		Details
config: add configure and quit command line option (2.92 KB, text/plain)
2015-02-16 16:49 UTC, Lubomir Rintel 		Details

Description Lubomir Rintel 2015-02-10 10:56:51 UTC 
Created attachment 296487 [details]
config: add configure and quit command line option

Useful for using the feature without having to hardcode it in configuration
(container set up scripts, development).
---
 src/nm-config.c | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 1 Jiri Klimes 2015-02-11 11:05:24 UTC 
I am for it.

But:
* use 'q' as a short option instead of 'd'
* I would use "Quit after initial configuration" instead of "Quit after performing configuration"
Comment 2 Lubomir Rintel 2015-02-16 16:49:22 UTC 
Created attachment 296953 [details]
config: add configure and quit command line option
Comment 3 Thomas Haller 2015-02-16 16:51:36 UTC 
LGTM
Comment 4 Thomas Haller 2015-02-16 16:52:24 UTC 
     char *plugins;
+    gboolean *configure_and_quit;
             ^^^
     char *connectivity_uri;
Comment 5 Lubomir Rintel 2015-02-16 17:14:49 UTC 
(In reply to Thomas Haller from comment #4)
>      char *plugins;
> +    gboolean *configure_and_quit;
>              ^^^
>      char *connectivity_uri;

Oops. Fixed and pushed.

bf6073b config: add configure and quit command line option