After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744194 - EggDateTime uses deprecated GtkArrow
EggDateTime uses deprecated GtkArrow
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Libegg maintenance
Libegg maintenance
Depends on:
Blocks:
 
 
Reported: 2015-02-09 22:59 UTC by Robert Ancell
Modified: 2015-03-09 16:40 UTC
See Also:
GNOME target: 3.16
GNOME version: ---

Attachments
EggDateTime: Don't use deprecated GtkArrow (2.90 KB, patch)
2015-02-09 23:43 UTC, Robert Ancell 		needs-work Details | Review

Description Robert Ancell 2015-02-09 22:59:41 UTC 
GtkArrow is deprecated. If you compile an app using EggDateTime with GTK_DISABLE_DEPRECATED you'll get errors like this:

libegg/egg-datetime.c: In function 'egg_datetime_init':
libegg/egg-datetime.c:504:4: warning: implicit declaration of function 'gtk_arrow_new' [-Wimplicit-function-declaration]
    arrow = gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_OUT);
Comment 1 Robert Ancell 2015-02-09 23:03:28 UTC 
This can segfault on architectures where the size of
a pointer is greater than the size of an integer, such as ia64 and amd64.
Comment 2 Robert Ancell 2015-02-09 23:04:09 UTC 
This code has been copied to (at least) seahorse (bug 744195)
Comment 3 Robert Ancell 2015-02-09 23:43:24 UTC 
Created attachment 296419 [details] [review]
EggDateTime: Don't use deprecated GtkArrow

I've copied the core of the rendering code from GTK+ to make this work. This probably means it's not themable - I'm not sure if that is an issue.
Comment 4 André Klapper 2015-03-09 11:42:34 UTC 
Setting GNOME 3.16 target here as it can trigger a crash in 744195
Comment 5 Matthias Clasen 2015-03-09 11:57:54 UTC 
Review of attachment 296419 [details] [review]:

Would have been less code (and themable) to do what the deprecation note recommends: Use GtkImage with pan-*-symbolic as icon name.