After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744184 - DBusActivatable flag interferes with jumplist actions
DBusActivatable flag interferes with jumplist actions
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 605551 746461 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-08 22:37 UTC by Casey Jao
Modified: 2015-04-18 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix desktop actions (12.58 KB, patch)
2015-03-19 14:58 UTC, Ignacio Casal Quinteiro (nacho)
reviewed Details | Review

Description Casey Jao 2015-02-08 22:37:58 UTC
Gedit on a standard Fedora 21 install comes with two jumplist actions: "Open a New Window" and "Open a New Document". Neither of those work out of the box.

The problem seems to be caused by the "DBusActivatable=True" line in the org.gnome.gedit desktop file. Removing that line restores the functionality of the additional actions.
Comment 1 Sébastien Wilmet 2015-02-10 14:37:12 UTC
I confirm the bug, thanks for the bug report.
Comment 2 Allison Karlitskaya (desrt) 2015-02-12 22:46:01 UTC
[Desktop Action Window]

[Desktop Action Document]

As per the desktop entry spec, gedit should be providing app actions named "Document" and "Window", which I am guessing it is not.

The correct fix is probably to rename these sections in the .desktop file to correspond to the correct GAction names.
Comment 3 Matthias Clasen 2015-02-12 22:48:33 UTC
[mclasen@localhost gtk]$ gdbus call --session --dest org.gnome.gedit --object-path /org/gnome/gedit --method org.gtk.Actions.List 
(['quit', 'new-window', 'preferences', 'about', 'help'],)
Comment 4 Allison Karlitskaya (desrt) 2015-02-12 22:50:53 UTC
(citation) http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s07.html :

"""

The ActivateAction method is called when Desktop Actions are activated. The action-name parameter is the name of the action.

"""
Comment 5 Matthias Clasen 2015-02-12 23:02:29 UTC
I must say the desktop entry spec is much less than clear about the requirements for Desktop Action sections. To spell it out:

if DBusActivatable is true, then

a) the action identifier must be the name of a GAction (as returned by the command above) and listed in the Actions key in the main section
b) activating the action has the effect of calling org.freedesktop.ActivateAction for the action identifier
c) the Exec key in the action section is ignored

if DBusActivatable is false, then

a) the action identifier can be any string, but must still be listed int he Actions key
b) activating the action uses the Exec key in the action section
Comment 6 Ignacio Casal Quinteiro (nacho) 2015-03-19 14:58:24 UTC
*** Bug 746461 has been marked as a duplicate of this bug. ***
Comment 7 Ignacio Casal Quinteiro (nacho) 2015-03-19 14:58:57 UTC
Created attachment 299834 [details] [review]
Fix desktop actions

https://bugzilla.gnome.org/show_bug.cgi?id=746461
Comment 8 Lars Karlitski 2015-03-20 08:52:59 UTC
Review of attachment 299834 [details] [review]:

Yup, that should do it.
Comment 9 Ignacio Casal Quinteiro (nacho) 2015-03-20 08:55:38 UTC
Attachment 299834 [details] pushed as 89268c6 - Fix desktop actions
Comment 10 Sébastien Wilmet 2015-03-30 10:53:28 UTC
I think the patch should be backported to gnome-3-14.
Comment 11 Florian Müllner 2015-03-31 20:18:07 UTC
*** Bug 605551 has been marked as a duplicate of this bug. ***
Comment 12 Sébastien Wilmet 2015-04-18 10:05:26 UTC
Commit backported to the gnome-3-14 branch:

https://git.gnome.org/browse/gedit/commit/?h=gnome-3-14&id=8fa00d0a56f073e0ac44a7de33203d893af4a841