GNOME Bugzilla – Bug 744182
Modify Chapter 1 Overview in Guide
Last modified: 2018-06-29 23:38:28 UTC
Patch to apply numerous editorial changes to improve Chapter 1: Overview in the Guide.
Created attachment 296401 [details] [review] Update Chapter 1 of Guide
Comment on attachment 296401 [details] [review] Update Chapter 1 of Guide Thank you for your patch David. Unfortunately I can't apply it to neither the master nor the maint branch. Trying to do so results in merge errors, that is git can't figure out where the changes should be applied in the original document. This is likely because you have other commits in between the upstream maint or master branch and this patch. This is where separate branches become important so that one patch doesn't depend on other ones that have not been committed yet.
Created attachment 310039 [details] [review] New Patch Attempt I hope that this patch will apply cleanly.
Thank for for the updated patch. It does apply cleanly this time which means you got it done properly in the "gitty" way :) When I ran make check in the gnucash-docs repository I reported a lot of xml errors with your patch. The core problem was that you had removed a <itemizedlist> and <listitem> tag but forgot to remove the closing tags as well. Since it was an easy fix I have already pushed it in a follow-up commit. For future patches please remember to run xmllint to validate your changes as explained here: http://wiki.gnucash.org/wiki/Documentation_Update_Instructions#Step_6_Validate_XML_Changes Thank you for your contributions ! I'm looking forward to your next ones.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=744182. Please update any external references or bookmarks.