GNOME Bugzilla – Bug 744172
Wayland: Clients won't work on compositors that support wl_seat < 4
Last modified: 2015-02-14 12:11:46 UTC
Created attachment 296391 [details] [review] Patch that respects lower wl_seat versions With commit 61f0ed80 the wl_seat requirement was bumped to version 4, instead of 3 however this will cause GTK+ clients to not work with compositors supporting a lower wl_seat version. A better practice would be to min-bound the version requirement. wl_seat 4 introduces a request for keyboard repeat information. The code seems to deal with the fact that this information might not be available, it only need to accept lower versions. It's not reasonable to expect all compositors have the latest version all at once, especially considering that a distro might ship a newer GTK+ version and an older compositor version.
Created attachment 296507 [details] [review] Add Reviewed by Daniel Stone Daniel Stone reviewed this patch on IRC
"seems to deal with" seems a bit weak... The commit message should say which compositors this patch was tested against.
> "seems to deal with" seems a bit weak... GdkWaylandDeviceData has a "have_server_repeat" field set to FALSE by default. It is set to TRUE only when the compositor offers repeat_info. When TRUE, GDK uses repeat_info from the compositor otherwise it will query GSettings for that information and fallsback to default values. This means that the code can already deal with missing repeat_info hence there's no reason to require wl_seat 4. > The commit message should say which compositors this patch was tested against. Updated
Created attachment 296560 [details] [review] patch v3
Review of attachment 296560 [details] [review]: ok, thanks
Thanks for the review, could you please push it? I don't believe I have the rights to do it, this was my first GTK+ patch.