GNOME Bugzilla – Bug 744164
applet: clean up code a bit
Last modified: 2017-09-27 07:46:38 UTC
The applet code needs some clean ups that are not closely related to any other bug reports. We talked about some of them in bug #740574. Let's use this bug for tracking the cleanup patches.
Created attachment 296368 [details] [review] rename nm_network_menu_item_class_dispose
Review of attachment 296368 [details] [review]: sure
Review of attachment 296368 [details] [review]: merged: https://git.gnome.org/browse/network-manager-applet/commit/?id=7f540dad150058716114a6ab0c6d4bcebfd712ce
Thanks. One of the next points might be to clean up `foo_set_icon()` and all the stuff around it.
Created attachment 297022 [details] [review] a trivial cleanup
Review of attachment 297022 [details] [review]: This patch was already (at time of posting) merged to master: https://git.gnome.org/browse/network-manager-applet/commit/?id=40f052d38af9e9f3bc42c6cbbb51e9044ab73663
Created attachment 297039 [details] [review] simple patch to be considered
Thanks, I'm often moving away patches from appindicator branch here, so it may happen that a patch gets merged without dcbw knowing it's here.
Created attachment 297047 [details] [review] GtkCheckMenuItem patch originally from appindicator patchset
Review of attachment 297039 [details] [review]: Doesn't apply anymore since https://git.gnome.org/browse/network-manager-applet/commit/?h=5455c67d58820b1050fff5dc31e5bbf89c92d769
Review of attachment 297047 [details] [review]: Doesn't apply anymore since https://git.gnome.org/browse/network-manager-applet/commit/?h=5455c67d58820b1050fff5dc31e5bbf89c92d769
All patches of this bug are either merged or are obsolted by other patches. Closing