After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744145 - Please recognize XDG_VTNR too
Please recognize XDG_VTNR too
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
unspecified
Other Linux
: Normal major
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-07 19:35 UTC by Samuel Thibault
Modified: 2015-02-17 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (760 bytes, patch)
2015-02-07 19:52 UTC, Samuel Thibault 		committed Details | Review

Description Samuel Thibault 2015-02-07 19:35:51 UTC 
Hello,

Orca knows that brlapi automatically use WINDOWPATH to determine which VT number it should acquire braille output on, but lightdm does not define it, and only define XDG_VTNR.  ATM, braille output of Orca only happens to work by pure luck, just because xbrlapi wasn't fixed either.  Upstream fixed xbrlapi recently, thus breaking Orca which needs to be fixed too.  The attached patch makes Orca aware of XDG_VTNR too, thus fixing braille output, could you apply it?

Thanks,
Samuel
Comment 1 Joanmarie Diggs (IRC: joanie) 2015-02-07 19:50:23 UTC 
I don't see the patch attached.
Comment 2 Samuel Thibault 2015-02-07 19:52:26 UTC 
Created attachment 296349 [details] [review]
proposed patch

Eeeh???  I guess the bts ate it... Anyway, here it is.
Comment 3 Samuel Thibault 2015-02-07 19:53:48 UTC 
My guess is that the BTS requires a description for the attachment, but doesn't complain about that when submitting the bug: it just submits the bug without the attachment...
Comment 4 Joanmarie Diggs (IRC: joanie) 2015-02-17 23:44:35 UTC 
Comment on attachment 296349 [details] [review]
proposed patch

Committed (with indentation tweaks) to both master and the gnome-3-14 branch. Thanks for the patch!