After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744109 - Low-resolution checkbox used in GNOME Clocks multi-select mode (probably also Documents, Photos etc)
Low-resolution checkbox used in GNOME Clocks multi-select mode (probably also...
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.15.x
Other Linux
: Normal minor
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-06 20:44 UTC by Adam Williamson
Modified: 2015-02-19 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot illustrating the issue (41.38 KB, image/png)
2015-02-06 20:44 UTC, Adam Williamson
  Details
fix selectionmode checkboxes (772 bytes, patch)
2015-02-18 19:35 UTC, Jakub Steiner
committed Details | Review

Description Adam Williamson 2015-02-06 20:44:21 UTC
Created attachment 296302 [details]
screenshot illustrating the issue

See attached screenshot. When you go into the 'select' mode in GNOME Clocks, the checkboxes used to indicate selections are clearly scaled up from a very low resolution, they look icky and jagged-y. This isn't even on a hidpi system.

I'd guess Photos and Documents would be the same, but neither of them launches on Rawhide ATM so I can't check.

This is with:

[adamw@adam Pictures]$ rpm -q gtk3 gnome-clocks
gtk3-3.15.4-1.fc22.x86_64
gnome-clocks-3.15.1-1.fc22.x86_64
Comment 1 Matthias Clasen 2015-02-12 01:18:40 UTC
Maybe a missing asset ?
Comment 2 Jakub Steiner 2015-02-12 10:52:47 UTC
Seems to be specific to Clocks. Documents and Photos use the specific large assets.
Comment 3 Jakub Steiner 2015-02-18 19:29:00 UTC
So the selection mode checkboxes expect the content-view class to be present for the icon view. I'll try providing patches for the few apps.
Comment 4 Jakub Steiner 2015-02-18 19:35:11 UTC
Created attachment 297147 [details] [review]
fix selectionmode checkboxes
Comment 5 Paolo Borelli 2015-02-19 09:15:56 UTC
Review of attachment 297147 [details] [review]:

Thanks for going out of your way and even touching the code!

If it is tested, go ahead
Comment 6 Paolo Borelli 2015-02-19 09:19:45 UTC
Note that the content-view class was removed in

https://git.gnome.org/browse/gnome-clocks/commit/?id=07db3f2cb122454101d572361b50deae43b9baad

following Lapo's suggestion.

Maybe double check if adding it back affects the background color?
Comment 7 Paolo Borelli 2015-02-19 13:23:55 UTC
I tested the patch and the background color still looks correct to me.
Comment 8 Paolo Borelli 2015-02-19 13:24:14 UTC
Review of attachment 297147 [details] [review]:

pushed