After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744108 - Creating an XFS file system never completes
Creating an XFS file system never completes
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2015-02-06 19:33 UTC by Mike Fleetwood
Modified: 2015-03-23 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix creating XFS file systems (v1) (1.84 KB, patch)
2015-02-06 19:37 UTC, Mike Fleetwood 		none Details | Review

Description Mike Fleetwood 2015-02-06 19:33:25 UTC 
I broke GParted's ability to create XFS file systems.  From the commit
message to fix it:


Trying to create an XFS file system causes the following error and
the create new xfs file system step to never complete.

    # ./gpartedbin
    ======================
    libparted : 2.4
    ======================

    (gpartedbin:15572): glibmm-CRITICAL **: 
    unhandled exception (type Glib::Error) in signal handler:
    domain: g-shell-error-quark
    code  : 0
    what  : Text ended before matching quote was found for ". (The text was 'mkfs.xfs -f -L "mylabel" " /dev/sdb8')

Creation of XFS file systems was broken by the extra stray double quote
added to the command before the device name, by commit:

    63aeb150ace06f678241f514c550e51b22d2f823
    Rename member variables and methods in Partition class (#741424)
Comment 1 Mike Fleetwood 2015-02-06 19:37:55 UTC 
Created attachment 296301 [details] [review]
Fix creating XFS file systems (v1)

Hi Curtis,

Here's the fix for my bug.

Thanks,
Mike
Comment 2 Curtis Gedak 2015-02-07 17:39:22 UTC 
Hi Mike,

Good work finding this error that we introduced, especially prior to packaging it into a release.  :-)

I confirmed both the problem and that the patch fixes the problem.

The patch in comment #1 has been committed to the git repository for inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:

Fix double quote error creating XFS file systems (#744108)
https://git.gnome.org/browse/gparted/commit/?id=70cc6187d510ce5c53349b8f02e7f495a12ce4a2

Curtis
Comment 3 Curtis Gedak 2015-03-23 17:46:41 UTC 
This enhancement was included in the GParted 0.22.0 release on March 23, 2015.