After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744094 - GtkSidebar is oddly named
GtkSidebar is oddly named
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-02-06 13:31 UTC by Lars Karlitski
Modified: 2015-02-13 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename GtkSidebar to GtkStackSidebar (29.48 KB, patch)
2015-02-12 17:36 UTC, Lars Karlitski 		committed Details | Review
prefs: GtkSidebar was renamed to GtkStackSidebar (1.51 KB, patch)
2015-02-12 17:44 UTC, Lars Karlitski 		committed Details | Review
Rename GtkSidebar to GtkSidebarWidget (3.20 KB, patch)
2015-02-12 22:28 UTC, Lars Karlitski 		none Details | Review

Description Lars Karlitski 2015-02-06 13:31:27 UTC 
GtkSidebar switches between pages of a stack, but its name doesn't reflect that. 

I'd expect a "GtkSidebar" to be a generic side bar widget and I can think of a lot of use-cases where we'd want a sidebar but not create all it's pages in a stack up-front, but rather lazily when switching pages.

I'm afraid we're blowing a good name here. Maybe rename it to GtkStackSidebar. That would fit nicely with GtkStackSwitcher as well.
Comment 1 Matthias Clasen 2015-02-11 12:54:25 UTC 
GtkStackSidebar would be ok with me, but I'm afraid this is going to cause some pain, close to .90.

Can we make a list of affected modules ?
Comment 2 Lars Karlitski 2015-02-12 17:36:01 UTC 
Created attachment 296702 [details] [review]
Rename GtkSidebar to GtkStackSidebar
Comment 3 Lars Karlitski 2015-02-12 17:44:29 UTC 
Created attachment 296705 [details] [review]
prefs: GtkSidebar was renamed to GtkStackSidebar

Fix for builder's preferences dialog.
Comment 4 Matthias Clasen 2015-02-12 21:18:04 UTC 
Review of attachment 296702 [details] [review]:

ok. Should probably rename gtksidebar.[hc] to gtkstacksidebar.[hc] too
Comment 5 Matthias Clasen 2015-02-12 21:19:12 UTC 
Glade needs a patch too. Also, if you push this, please send a mail to let people know - maybe d-d-l ?
Comment 6 Lars Karlitski 2015-02-12 22:28:04 UTC 
Created attachment 296722 [details] [review]
Rename GtkSidebar to GtkSidebarWidget

Patch for glade.
Comment 7 Lars Karlitski 2015-02-13 17:02:35 UTC 
Attachment 296702 [details] pushed as f3110e4 - Rename GtkSidebar to GtkStackSidebar
Comment 8 Christian Hergert 2015-02-13 19:53:27 UTC 
Review of attachment 296705 [details] [review]:

Looks like this is committed.