GNOME Bugzilla – Bug 744088
vaapipostproc: Add support for Skin Tone Enhancement
Last modified: 2015-06-12 15:07:39 UTC
Add support for SkinToneEnhancement (which in already supported by the intel-vaapi-driver) to vaapipostproc.
Created attachment 303831 [details] [review] vaapipostproc: add skin tone enhancement
Created attachment 304677 [details] [review] vaapipostproc: add skin tone enhancement Added the 'skin-tone-enhancement' property to vaapostproc.
Created attachment 304678 [details] [review] patch for gst-player for testing the skin tone enhancement in videos patch for gst-player[1] for testing the skin tone enhancement in videos 1. https://github.com/sdroege/gst-player
Review of attachment 304677 [details] [review]: Some minor changes to make, but overall LGTM. ::: gst-libs/gst/vaapi/gstvaapifilter.h @@ +45,3 @@ + * @GST_VAAPI_FILTER_OP_SCALING: Change scaling method + * (#GstVaapiScaleMethod). + * @GST_VAAPI_FILTER_OP_SKINTONE: Skin tone enhancement (none). Please, do not re-indent other filter descriptions. Thanks. The argument description should probably reflect: (bool) as the way it is currently used is exactly this, an on/off toggle. Reminder: the GstVaapiFilter is live until destroyed, so it might be useful to disable it.
(In reply to Víctor Manuel Jáquez Leal from comment #3) > Created attachment 304678 [details] [review] [review] > patch for gst-player for testing the skin tone enhancement in videos > > patch for gst-player[1] for testing the skin tone enhancement in videos > > 1. https://github.com/sdroege/gst-player And do you visibly see a difference with STE enabled? :)
Side note: we might need to turn the bool into a float that represents the magnitude of STE color correction to apply? Not sure about it though.
(In reply to Gwenole Beauchesne from comment #5) > (In reply to Víctor Manuel Jáquez Leal from comment #3) > > Created attachment 304678 [details] [review] [review] [review] > > patch for gst-player for testing the skin tone enhancement in videos > > > > patch for gst-player[1] for testing the skin tone enhancement in videos > > > > 1. https://github.com/sdroege/gst-player > > And do you visibly see a difference with STE enabled? :) Yup. The skin turned from greenish to redish... But! in my hardware (Haswell), with 1080p videos, the frames appear like bumping, very annoying. Lower resolutions don't show that problem.
Created attachment 304792 [details] [review] vaapipostproc: add skin tone enhancement Added the 'skin-tone-enhancement' property to vaapostproc.
I have setup a branch for gst-player to play with vaapipostproc controls using gtk ui: https://github.com/ceyusa/gst-player/tree/vaapipostproc
Review of attachment 304792 [details] [review]: OK
Attachment 304792 [details] pushed as 1ef8c10 - vaapipostproc: add skin tone enhancement