After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744086 - configure.ac: Pull gio-unix dependency for all unix builds
configure.ac: Pull gio-unix dependency for all unix builds
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-02-06 10:27 UTC by Marco Trevisan (Treviño)
Modified: 2015-05-14 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure.ac: Pull gio-unix dependency for all unix builds (2.43 KB, patch)
2015-02-06 10:27 UTC, Marco Trevisan (Treviño) 		none Details | Review
configure.ac: Pull gio-unix dependency for all unix builds (2.65 KB, patch)
2015-05-07 09:57 UTC, Marco Trevisan (Treviño) 		accepted-commit_now Details | Review

Description Marco Trevisan (Treviño) 2015-02-06 10:27:37 UTC 
It's now needed by gtk-launch, so it's just the case to enable it for all the
builds except the win32 one, instead of adding it for every unix backend.
Comment 1 Marco Trevisan (Treviño) 2015-02-06 10:27:40 UTC 
Created attachment 296259 [details] [review]
configure.ac: Pull gio-unix dependency for all unix builds

It's now needed by gtk-launch, so it's just the case to enable it for all the
builds except the win32 one, instead of adding it for every unix backend.
Comment 2 Lars Karlitski 2015-05-07 09:37:22 UTC 
Review of attachment 296259 [details] [review]:

This makes sense to me. Please update the patch to also remove the "have_gio_unix=yes" line from the mir check, which was added recently.
Comment 3 Marco Trevisan (Treviño) 2015-05-07 09:57:37 UTC 
Created attachment 303020 [details] [review]
configure.ac: Pull gio-unix dependency for all unix builds

It's now needed by gtk-launch, so it's just the case to enable it for all the
builds except the win32 one, instead of adding it for every unix backend.
Comment 4 Matthias Clasen 2015-05-14 03:31:43 UTC 
Review of attachment 303020 [details] [review]:

.