GNOME Bugzilla – Bug 744047
Port acmmp3dec plugin to 1.x
Last modified: 2015-12-15 10:11:50 UTC
Created attachment 296200 [details] [review]
This patch is based on the one work done in bug 740945. I only tested it with gst-launch-1.0 and some mp3 files (including those of bug 548753 comment 5) and I didn't built it with other compilers than MinGW.
Created attachment 296572 [details] [review]
Updating patch, since gst_buffer_fill was incorrectly used in the previous version.
Created attachment 299184 [details] [review]
OK, I've stopped working on this for some time but before it is lost, I'm uploading my latest patch where I also tried to port acmenc to 1.x (claiming "acm" to be ported in configure.ac was not very correct in the previous version since I only ported the mp3 decoder). Note however that I didn't figure out how to make the acm encoders work...
Can someone please review the patch? Thanks!
Is the patch complete? You said you stopped working on it, what is missing? :)
As far as I remember, I only used the mp3 decoder. I fixed build error for the encoder but I don't think I've figured out how to test it. Also, I don't know if more things are needed for the build config files.
Author: Frédéric Wang <firstname.lastname@example.org>
Date: Thu Mar 12 11:29:00 2015 +0000
acm: Port ACM MP3 decoder and encoders to GStreamer 1.x