After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744047 - Port acmmp3dec plugin to 1.x
Port acmmp3dec plugin to 1.x
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-05 15:32 UTC by Frédéric Wang
Modified: 2015-12-15 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch V1 (5.91 KB, patch)
2015-02-05 15:32 UTC, Frédéric Wang 		none Details | Review
Patch V2 (5.92 KB, patch)
2015-02-11 09:24 UTC, Frédéric Wang 		none Details | Review
Patch V3 (10.92 KB, patch)
2015-03-12 11:29 UTC, Frédéric Wang 		committed Details | Review

Description Frédéric Wang 2015-02-05 15:32:37 UTC 
Created attachment 296200 [details] [review]
Patch V1

This patch is based on the one work done in bug 740945. I only tested it with gst-launch-1.0 and some mp3 files (including those of bug 548753 comment 5) and I didn't built it with other compilers than MinGW.
Comment 1 Frédéric Wang 2015-02-11 09:24:19 UTC 
Created attachment 296572 [details] [review]
Patch V2

Updating patch, since gst_buffer_fill was incorrectly used in the previous version.
Comment 2 Frédéric Wang 2015-03-12 11:29:50 UTC 
Created attachment 299184 [details] [review]
Patch V3

OK, I've stopped working on this for some time but before it is lost, I'm uploading my latest patch where I also tried to port acmenc to 1.x (claiming "acm" to be ported in configure.ac was not very correct in the previous version since I only ported the mp3 decoder). Note however that I didn't figure out how to make the acm encoders work...
Comment 3 Frédéric Wang 2015-07-16 14:17:14 UTC 
Can someone please review the patch? Thanks!
Comment 4 Sebastian Dröge (slomo) 2015-12-04 14:20:01 UTC 
Is the patch complete? You said you stopped working on it, what is missing? :)
Comment 5 Frédéric Wang 2015-12-04 16:39:42 UTC 
As far as I remember, I only used the mp3 decoder. I fixed build error for the encoder but I don't think I've figured out how to test it. Also, I don't know if more things are needed for the build config files.
Comment 6 Sebastian Dröge (slomo) 2015-12-07 11:27:02 UTC 
commit 47d2a13d48e1b227e0566be9386a0864a27dfdfa
Author: Frédéric Wang <fred.wang@free.fr>
Date:   Thu Mar 12 11:29:00 2015 +0000

    acm: Port ACM MP3 decoder and encoders to GStreamer 1.x
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744047
Comment 7 Frédéric Wang 2015-12-15 10:11:50 UTC 
Thank you!