After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744025 - CRITICAL **: load_failed_cb: assertion '(error->domain == WEBKIT_NETWORK_ERROR) || (error->domain == WEBKIT_POLICY_ERROR) || (error->domain == WEBKIT_PLUGIN_ERROR)' failed
CRITICAL **: load_failed_cb: assertion '(error->domain == WEBKIT_NETWORK_ERRO...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.14.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-05 02:45 UTC by Michael Catanzaro
Modified: 2015-02-05 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show a network error page when a G_TLS_ERROR is received (1.07 KB, patch)
2015-02-05 02:46 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2015-02-05 02:45:09 UTC 
What should we do about this error:

CRITICAL **: load_failed_cb: assertion '(error->domain == WEBKIT_NETWORK_ERROR) || (error->domain == WEBKIT_POLICY_ERROR) || (error->domain == WEBKIT_PLUGIN_ERROR)' failed

This is because in ephy-web-view.c, load_failed_cb, we expect the error domain of the returned GError to be SOUP_HTTP_ERROR, or one of those three WebKit error domains. Now visit this broken site (with TLS version intolerance): https://www.timewarnercable.com/

You get a G_TLS_ERROR. I think the assertion is in Ephy wrong because WebKitWebView:load-failed is not documented to have any restrictions on the errors it returns.
Comment 1 Michael Catanzaro 2015-02-05 02:46:59 UTC 
Created attachment 296166 [details] [review]
Show a network error page when a G_TLS_ERROR is received

We don't expect a G_TLS_ERROR here, so we hit the g_return_val_if_fail
and wind up displaying a blank page with the error message in plain
text. We should display the network error page instead.
Comment 2 Carlos Garcia Campos 2015-02-05 08:16:37 UTC 
Review of attachment 296166 [details] [review]:

Yes. Thanks!
Comment 3 Michael Catanzaro 2015-02-05 14:22:32 UTC 
Attachment 296166 [details] pushed as 7a9d5fb - Show a network error page when a G_TLS_ERROR is received