GNOME Bugzilla – Bug 744001
[PATCH] New histogram plugin for GRAY8 images
Last modified: 2018-11-03 13:30:23 UTC
This patchset creates a new histogram element for calculating histogram metadata from a video stream. The plugin provides 2 elements: vhist: An element for extracting histogram data from a stream. It can take a single parameter, called "binno" for defining the number of bins. This component calculates the histogram data for the provided image and adds it to the pipeline using the gstmeta subsystem. drawhist: A visualizer of the calculated metadata. Requires that metadata be appended to the stream. The resulting output is a GREY8 image of the histogram. To test the plugin, the following pipeline can be used: gst-launch-1.0 videotestsrc ! vhist binno=5 ! drawhist ! videoconvert ! ximagesink
Created attachment 296141 [details] [review] Histogram element
Created attachment 296142 [details] [review] Cover letter
Created attachment 296143 [details] [review] Histogram metadata visualizer
I see you have marked this as OS=Linux, but in my quick read I don't see a reason it couldn't be in all other platforms. Is this cross platform? or has any specific Linux dependencies?
I think bugzilla sets the OS field based on the browser agent
You are correct, I did not set the OS field. As far as I am aware the code can run on any platform. I haven't tested it on windows and do not have a mac though so I can't be 100% I haven't overlooked something :) I have also made a second version of the histogram that runs only for bin sizes with powers of 2. That allows me to perform binning with binary operations rather than using floats and should be faster. I am also using gcc intrinsics for it so if you would prefer the second implementation I would like to know if gcc is a hard dependency so I can implement an alternative operation in the case it is not.
Tim, Would this be OK to push through after review/cleaning before the pre-release or should we punt it 1.7? Just curious.
FWIW there is also a similar element based on opencv here: https://bugzilla.gnome.org/show_bug.cgi?id=635646
Created attachment 296589 [details] [review] Bug fix for histogram component I added an additional patch for the histogram component, there was a mistake with the histgram maximum size and an old histogram API name
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/207.