After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743923 - [PATCH] Cannot create a saved search for photos that have an unset title
[PATCH] Cannot create a saved search for photos that have an unset title
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: search
unspecified
Other Linux
: Normal normal
: 0.22
Assigned To: Shotwell Maintainers
Shotwell Maintainers
: 725422 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-03 11:23 UTC by Brian Masney
Modified: 2015-02-10 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the issue (659 bytes, patch)
2015-02-03 11:25 UTC, Brian Masney 		rejected Details | Review
Version 2 of the patch (774 bytes, patch)
2015-02-04 02:36 UTC, Brian Masney 		none Details | Review

Description Brian Masney 2015-02-03 11:23:25 UTC 
I created a saved search with the criteria 'Title is not set' and nothing showed up. The attached patch fixes this issue.
Comment 1 Brian Masney 2015-02-03 11:25:12 UTC 
Created attachment 296008 [details] [review]
Patch to fix the issue
Comment 2 Jim Nelson 2015-02-04 01:48:12 UTC 
Review of attachment 296008 [details] [review]:

Running with logging set, when I create this saved search with your patch I get a tremendous number of these warnings:

(shotwell:11893): GLib-CRITICAL **: g_utf8_strdown: assertion 'str != NULL' failed
L 11893 2015-02-03 17:45:50 [CRT] string_remove_diacritics: assertion 'istring != NULL' failed

Additionally, when I run from master, a "no title set" saved search finds a number of photos and videos in my collection.  What are you seeing?
Comment 3 Brian Masney 2015-02-04 02:36:42 UTC 
Created attachment 296060 [details] [review]
Version 2 of the patch

Sorry about the first patch. I missed the assertion errors on the console. I included a second patch and verified that no assertion errors appear on the console.

Brian
Comment 4 Jim Nelson 2015-02-04 02:41:24 UTC 
Got it.  I also now see what you're fixing!

Pushed to master, commit 4c7455
Comment 5 Jim Nelson 2015-02-10 21:57:11 UTC 
*** Bug 725422 has been marked as a duplicate of this bug. ***