After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743910 - videocrop: crash when launching with different properties
videocrop: crash when launching with different properties
Status: RESOLVED DUPLICATE of bug 743909
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal major
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-03 06:10 UTC by Vineeth
Modified: 2015-04-23 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vineeth 2015-02-03 06:10:15 UTC 
When the top/left/right/bottom values are anything more than video width/height, then the pipeline crashes.
Sample pipeline is as follows.

gst-launch-1.0 videotestsrc num-buffers=20 ! videcrop bottom=214748364 ! videoconvert ! autovideosink


The values should be handled properly as per video height/width
Comment 1 Nicolas Dufresne (ndufresne) 2015-02-03 15:45:38 UTC 
Confirmed.
Comment 2 Vincent Penquerc'h 2015-04-06 16:37:37 UTC 
I get no crash with latest master, I get a buffer pool error and the pipeline stops properly. No uninitialized reports from valgrind.
Comment 3 Vincent Penquerc'h 2015-04-07 10:43:15 UTC 
There was a leak on the error path triggered by this test case, fixed by:

commit 84fdf50b2f98951a32fa14802b62621f1105cd35
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Apr 7 11:38:31 2015 +0100

    basesrc: fix pool leak on allocation query error path
    
    It could be triggered by:
    
    gst-launch-1.0 videotestsrc num-buffers=20 ! videcrop bottom=214748364 ! videoconvert ! autovideosink
    
    Spotted while testing:
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743910


Nicolas, were you using latest master when you reproduced the crash ?
Comment 4 Vincent Penquerc'h 2015-04-15 10:30:56 UTC 
I just tried again, and I'm getting the crash now. Debugging.
Comment 5 Vincent Penquerc'h 2015-04-15 10:42:31 UTC 
The leak above got fixed twice - by myself, and by someone else - leading to a double free after the merge did not conflict. Fixed. So I'm still not getting the original reported crash.
Comment 6 Vineeth 2015-04-23 06:23:10 UTC 
Hi Vincent,


The crash is same as videobox crash in 743909. I have updated the stack in that bug.
Funny part is, it crashes when bottom=1677722, but does not when it is bottom=1677721. So there is some logic which needs to be checked.
Comment 7 Tim-Philipp Müller 2015-04-23 19:15:56 UTC 
Let's merge those two bugs then if they're virtually identical..

*** This bug has been marked as a duplicate of bug 743909 ***