GNOME Bugzilla – Bug 743854
Toggles for ready-made searches
Last modified: 2018-01-11 10:13:37 UTC
Just like in Documents app, it would be nice to provide toggles for ready searches like "Remote boxes", "Virtual boxes", "Local boxes" etc: https://bugzilla.gnome.org/show_bug.cgi?id=736972#c3
Created attachment 306084 [details] Screenshot of a search menu prototype Is this the kind of UI we want or did I misunderstand this bug? Or did you want a set of buttons in the headerbar acting as page switchers?
(In reply to Adrien Plazas from comment #1) > Created attachment 306084 [details] > Screenshot of a search menu prototype > > Is this the kind of UI we want or did I misunderstand this bug? > Or did you want a set of buttons in the headerbar acting as page switchers? headerbar as page switchers please. :)
(In reply to Zeeshan Ali (Khattak) from comment #2) > (In reply to Adrien Plazas from comment #1) > > Created attachment 306084 [details] > > Screenshot of a search menu prototype > > > > Is this the kind of UI we want or did I misunderstand this bug? > > Or did you want a set of buttons in the headerbar acting as page switchers? > > headerbar as page switchers please. :) Actually I think this bug is about the search toggles like in your mockup. I thought we had a bug about switchers but I can't find it so feel free to file a new one for that if you're going to implement that. I think page switchers are more important, though in there we have be extremely selective of which switches we want.
Actually it's not a mockup but a screenshot. =p Ok I'll work on adding page switchers. Do you know how to discriminate local machines from remote ones and physical machines from virtual ones? I always thought LibvirtMachine represented local virtual machines and RemoteMachine represented remote machine (physical or virtual). A page I _don't_ want to see is a "Favorites" one, it wouldn't make much sens as favorites are already extremely visible when displaying all the available machines.
(In reply to Adrien Plazas from comment #4) > Actually it's not a mockup but a screenshot. =p > > Ok I'll work on adding page switchers. Do you know how to discriminate local > machines from remote ones and physical machines from virtual ones? I always > thought LibvirtMachine represented local virtual machines and RemoteMachine > represented remote machine (physical or virtual). That's a start but I think we'll have to be smarter than that since there are remote libvirt machine case. Basically you gotta check the URI (Machine.source.uri). * For LibvirtMachine, that will be qemu:///session or qemu:///system. Otherwise it's remote. * For Remote, you'll have to check if IP is local or not. Alternatively you can just check if IP is local or not for all machine types. I just started working on bug#744004 and my plan is to add an 'ip' property to Machine class so you can rely on that once I'm done. > A page I _don't_ want to see is a "Favorites" one, it wouldn't make much > sens as favorites are already extremely visible when displaying all the > available machines. Hmm.. yeah considering that we always put them in front of non-favorite ones. It would be a good work around for bug#751478 but not really a fan of working around issue with adding clutter to UI. :)
Created attachment 306276 [details] [review] app-window: Put collection view in stack Move the window's collection view in a Gtk.Stack. This is needed to allow to switch between multiple collection views to offer multiple ready-made searches.
Created attachment 306277 [details] [review] collection-toolbar: Add collection view switcher Add a Gtk.StackSwitcher as the collection toolbar's custom title widget, allowing to switch between the window's multiple collection views. This is needed to allow to switch between multiple collection views to offer multiple ready-made searches.
Created attachment 306278 [details] [review] collection: Add CollectionFilterFunc delegate Add the CollectionFilterFunc delegate, allowing to filter a single collection element. This will be used in next commits to filter the visible elements of a collection and is needed to offer multiple ready-made searches.
Created attachment 306279 [details] [review] collection-view: Add 'item_visible_func' prop Add the 'item_visible_func' delegate allowing to filter visible items of the collection view. This is needed to filter the visible elements of a collection and to offer multiple ready-made searches.
These patches don't add searches/pages, but they add everything needed to add them. Adding new searches is simple: - add a new CollectionView as a page to AppWindow.views, - apply the same treatment to it than AppWindow.all_view (by searching where it is used in app-window.vala), - then just set this new page's "item_visible_func" property, and voilà!
(In reply to Adrien Plazas from comment #10) > These patches don't add searches/pages, but they add everything needed to > add them. Great! I'll review once they add a functionality. :)
Now all we need to know is what categories we want. Basically: - can we tell if a remote machine is virtual or physical? - can a local machine be another thing than virtual? If both are false, there are two groups of boxes we can know about: - local virtual machines - remotes machines (virtual or physical) Meaning that having a tab for virtual machines may not be a good idea, and we would only have the "Local" and "Remote" tabs alongside the "All" tab.
(In reply to Adrien Plazas from comment #12) > Now all we need to know is what categories we want. > > Basically: > - can we tell if a remote machine is virtual or physical? Yes kinda, we have different classes for dealing with different kinds of machines. If it's LibvirtMachine or OvirtMachine instance, its a VM. If it's RemoteMachine, well we shouldn't care in that case. > - can a local machine be another thing than virtual? Theoretcially, yes. You can setup a vnc or spice connection to host and use Boxes to access it on the same host but it's not at all a use case. > If both are false, there are two groups of boxes we can know about: > - local virtual machines > - remotes machines (virtual or physical) Sure. I'd name them: - Local - Remote > Meaning that having a tab for virtual machines may not be a good idea, and > we would only have the "Local" and "Remote" tabs alongside the "All" tab. But please keep in mind this is not the appropriate bug for page switchers, as pointed out in comment#3.
*** Bug 751727 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/41.