After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743853 - Use edge-reached signal instead of edge-overshot
Use edge-reached signal instead of edge-overshot
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-02 13:41 UTC by Pranav Kant
Modified: 2015-02-02 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
view-container: use edge-reached signal instead of edge-overshot (1.34 KB, patch)
2015-02-02 13:41 UTC, Pranav Kant 		needs-work Details | Review
view-container: Use edge-reached signal instead of edge-overshot (1.34 KB, patch)
2015-02-02 14:02 UTC, Pranav Kant 		committed Details | Review

Description Pranav Kant 2015-02-02 13:41:39 UTC 
edge-overshot doesn't work fine for touchpad scrolling. See
https://bugzilla.gnome.org/show_bug.cgi?id=742848
Comment 1 Pranav Kant 2015-02-02 13:41:44 UTC 
Created attachment 295941 [details] [review]
view-container: use edge-reached signal instead of edge-overshot

edge-overshot only works fine for touchpad scrolling but fails when
scrollbar is dragged to the end.
Comment 2 Debarshi Ray 2015-02-02 13:53:33 UTC 
Review of attachment 295941 [details] [review]:

Thanks for the patch, Pranav.

::: configure.ac
@@ +32,3 @@
 GOA_MIN_VERSION=3.8.0
 GRILO_MIN_VERSION=0.2.6
+GTK_MIN_VERSION=3.15.4

It should be 3.15.5. The new signal was added in 404e2753 and it is not part of the 3.15.4 release.
Comment 3 Pranav Kant 2015-02-02 14:02:14 UTC 
Created attachment 295945 [details] [review]
view-container: Use edge-reached signal instead of edge-overshot

edge-overshot only works fine for touchpad scrolling but fails when
scrollbar is dragged to the end.
Comment 4 Debarshi Ray 2015-02-02 14:05:23 UTC 
Review of attachment 295945 [details] [review]:

Perfect.