GNOME Bugzilla – Bug 743848
g_file_move: remove G_FILE_COPY_NOFOLLOW_SYMLINKS section
Last modified: 2018-05-24 17:24:34 UTC
Created attachment 295937 [details] [review] g_file_move: remove G_FILE_COPY_NOFOLLOW_SYMLINKS from docs G_FILE_COPY_NOFOLLOW_SYMLINKS flag doesn't make sense for move operation, either local implementation doesn't handle this flag in no way. Therefore this paragraph should be removed from the docs (because it was probably copy&pasted from g_file_copy by mistake).
Review of attachment 295937 [details] [review]: This makes sense, but I think G_FILE_COPY_NOFOLLOW_SYMLINKS *can* affect the behaviour of g_file_move(). If it ends up on its fallback code path which uses g_file_copy()/g_file_delete(), the move flags will be passed almost-unmodified into g_file_copy(), at which point G_FILE_COPY_NOFOLLOW_SYMLINKS could make a difference. Do we want to mask it out?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/986.