After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743827 - Fix build of GListModel (on Visual Studio)
Fix build of GListModel (on Visual Studio)
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-02-02 05:32 UTC by Fan, Chun-wei
Modified: 2015-02-02 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix definition of _GListModelInterface in glistmodel.h (802 bytes, patch)
2015-02-02 05:35 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2015-02-02 05:32:58 UTC 
Hi,

In the definition of _GListModelInterface (in glistmodel.h), there is the use of "interface" in one of the members of the structure, which is a reserved word in Visual Studio, which would break the build.

I will attach a very simple patch in a bit that fixes this build problem (and the test of the API passes with it).

With blessings, thank you in advance.
Comment 1 Fan, Chun-wei 2015-02-02 05:35:16 UTC 
Created attachment 295914 [details] [review]
Fix definition of _GListModelInterface in glistmodel.h

Hi,

Please see the patch.

With blessings, thank you!
Comment 2 Allison Karlitskaya (desrt) 2015-02-02 08:26:16 UTC 
Is this a problem even in C mode?
Comment 3 Fan, Chun-wei 2015-02-02 08:28:10 UTC 
Hello Ryan,

It is, .c files are treated as C mode by default.

With blessings.
Comment 4 Dan Winship 2015-02-02 08:52:41 UTC 
(In reply to comment #2)
> Is this a problem even in C mode?

yeah, one of the win32 headers does

  #define interface struct
Comment 5 Allison Karlitskaya (desrt) 2015-02-02 10:17:54 UTC 
Committed with a small tweak: usually we call this 'g_iface'.

Thanks!