GNOME Bugzilla – Bug 743708
libgitg/gitg-credentials-manager.vala:254.11-254.48: error: `Ggit.CredSshKeyFromAgent' does not have a default constructor
Last modified: 2019-02-22 03:51:45 UTC
gitg master does not build anymore in jhbuild (so I'm using the master branch of all dependencies). libgitg/gitg-credentials-manager.vala:254.11-254.48: error: `Ggit.CredSshKeyFromAgent' does not have a default constructor return new Ggit.CredSshKeyFromAgent(username); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Compilation failed: 1 error(s), 1 warning(s) Which seems to be a terrible error message from Vala. I see this in ggit-1.0.vapi: [CCode (cheader_filename = "libgit2-glib/ggit.h")] [Compact] public class CredSshKeyFromAgent { } I'm not sure what's going wrong there.
Your libgit2 doesn't support ssh. Rebuild libgit2 with -DUSE_SSH=ON, then rebuild libgit2-glib. This should fix your problem.
Ugh, libssh is not in jhbuild. Well it looks like libgit2 doesn't depend on any particular version, so I will add it as a sysdep.
The following fixes have been pushed: 62e70e3 apps-3.16: libgit2 should be built with SSH support a4113b7 sysdeps-3.16: add libssh
Created attachment 297546 [details] [review] apps-3.16: libgit2 should be built with SSH support gitg wants to use SSH support in libgit2. It will be selected automatically if libssh-devel is installed.
Created attachment 297547 [details] [review] sysdeps-3.16: add libssh Needed for libgit2. Its pkg-config file was added in 2009 and there's no version requirement, so no worries.
The following fix has been pushed: b538426 sysdeps-3.16: fixup for libssh
Created attachment 297548 [details] [review] sysdeps-3.16: fixup for libssh
Are you sure that works? because the dependency if I recall correctly is on libssh2 and for istance in fedora there are both libssh and libssh2
Yup it's wrong, good catch!
The following fix has been pushed: 608b135 sysdeps-3.16: another fixup for libssh
Created attachment 297569 [details] [review] sysdeps-3.16: another fixup for libssh There is libssh.pc and also libssh2.pc. We need libssh2.
Review of attachment 297569 [details] [review]: I'd also change the module name since they are two different projetcs
Goodness gracious :)
The following fix has been pushed: c8f265c 3.16: rename libssh to libssh2
Created attachment 297590 [details] [review] 3.16: rename libssh to libssh2 As has been pointed out, these are two competing libraries, not two different versions of the same library. Goodness gracious. Can't wait to see what happens when libssh bumps their pkg-config version....