After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743656 - typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE
typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-01-28 16:29 UTC by Xavier Claessens
Modified: 2015-02-03 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Doc: fix typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE (2.79 KB, patch)
2015-01-28 16:29 UTC, Xavier Claessens 		none Details | Review
Doc: fix typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE (3.23 KB, patch)
2015-01-28 16:38 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2015-01-28 16:29:26 UTC 
patch coming
Comment 1 Xavier Claessens 2015-01-28 16:29:57 UTC 
Created attachment 295676 [details] [review]
Doc: fix typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE
Comment 2 Ignacio Casal Quinteiro (nacho) 2015-01-28 16:34:05 UTC 
Review of attachment 295676 [details] [review]:

See comment not related to your patch, but since you are at it... :)

::: gobject/gtype.h
@@ +1344,1 @@
  * G_DECLARE_FINAL_TYPE (MyAppWindow, my_app_window, GtkWindow, MY_APP, WINDOW)

isn't this example also wrong? shouldn't GtkWindow be the last parameter?
Comment 3 Xavier Claessens 2015-01-28 16:38:08 UTC 
Created attachment 295679 [details] [review]
Doc: fix typos in G_DECLARE_FINAL_TYPE and G_DECLARE_DERIVABLE_TYPE
Comment 4 Xavier Claessens 2015-01-28 16:39:11 UTC 
I think you're right nacho, fixed that as well now :)