After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743626 - prepend_terminal_to_vector() should honor x-terminal-emulator
prepend_terminal_to_vector() should honor x-terminal-emulator
Status: RESOLVED DUPLICATE of bug 627943
Product: glib
Classification: Platform
Component: gio
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
Depends on:
Reported: 2015-01-28 09:34 UTC by Romano Giannetti
Modified: 2015-01-28 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

This is an example patch to add x-terminal-emulator default support --- but it's quite clumsy. (2.37 KB, patch)
2015-01-28 09:34 UTC, Romano Giannetti
none Details | Review

Description Romano Giannetti 2015-01-28 09:34:17 UTC
Created attachment 295624 [details] [review]
This is an example patch to add x-terminal-emulator default support --- but it's quite clumsy.

prepend_terminal_to_vector() uses a hard coded list of terminals to try to execute a command with a terminal emulator, with even a workaround for a gnome-terminal "-e" parameter strangeness. 

In my opinion, the first terminal to check should be x-terminal-emulator, so that people that use the alternative mechanism to install a different default terminal emulator would not have unexpected results. 

Notice that if the x-terminal-emulator happens to be set to gnome-terminal, in this case the "brokeness" (different behavior?)  of gnome-terminal -e is taken care of in /usr/bin/gnome-terminal.wrapper. 

Added a sub-optimal, example-only patch. 

Thank you very much.
Comment 1 Romano Giannetti 2015-01-28 09:40:16 UTC
As an example of unexpected results, if you install the nautilus-open-terminal extension, you will have a gnome-terminal opened (if installed) no matter what the update-alternative setting is.
Comment 2 Matthias Clasen 2015-01-28 13:26:50 UTC

*** This bug has been marked as a duplicate of bug 627943 ***