After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743580 - query_fs_info crash when file not found
query_fs_info crash when file not found
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: mtp backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Philip Langdale
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-27 14:09 UTC by Ondrej Holy
Modified: 2015-01-27 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix query_fs_info crash when file not found (1.05 KB, patch)
2015-01-27 14:09 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-01-27 14:09:43 UTC 
Created attachment 295537 [details] [review]
fix query_fs_info crash when file not found

The query_fs_info function isn't returned after g_vfs_job_failed_literal, therefore g_vfs_job_succeeded is executed and it fails on assert.

Truncated backtrace:
Thread no. 1 (6 frames)
 #2 _g_log_abort at /lib64/libglib-2.0.so.0
 #5 g_vfs_job_emit_finished
 #6 _g_closure_invoke_va at /lib64/libgobject-2.0.so.0
 #9 do_query_fs_info
 #10 g_vfs_job_run
 #12 g_thread_proxy at /lib64/libglib-2.0.so.0

Downstream bugreports:
https://bugzilla.redhat.com/show_bug.cgi?id=1071526
https://bugzilla.redhat.com/show_bug.cgi?id=1178317
Comment 1 Philip Langdale 2015-01-27 15:50:24 UTC 
Review of attachment 295537 [details] [review]:

Thanks!
Comment 2 Ondrej Holy 2015-01-27 16:03:49 UTC 
Comment on attachment 295537 [details] [review]
fix query_fs_info crash when file not found

Thanks for review! Committed to master (dc8db93), gnome-3-14 (38f2ea9), gnome-3-12 (595baef) and gnome-3-10 (6551cd4) branch.