After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743576 - Typing an Hebrew character into the global search crashes builder
Typing an Hebrew character into the global search crashes builder
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-27 12:11 UTC by Elad Alfassa
Modified: 2015-01-27 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
git: ignore non-ascii characters when searching fulltext index (2.15 KB, patch)
2015-01-27 16:30 UTC, Christian Hergert 		committed Details | Review

Description Elad Alfassa 2015-01-27 12:11:12 UTC 
My keyboard layout was accidentally on Hebrew when I tried to use the global search, which lead to this crash:

+ Trace 234597

  • #0 fuzzy_match
    at src/fuzzy/fuzzy.c line 493
  • #1 gb_git_search_provider_populate
    at src/git/gb-git-search-provider.c line 300
  • #2 gb_search_context_execute
    at src/search/gb-search-context.c line 111
  • #3 gb_search_box_delay_cb
    at src/search/gb-search-box.c line 122
  • #4 g_timeout_dispatch
    at gmain.c line 4545
  • #5 g_main_dispatch
    at gmain.c line 3122
  • #6 g_main_context_dispatch
    at gmain.c line 3737
  • #7 g_main_context_iterate
    at gmain.c line 3808
  • #8 g_main_context_iteration
    at gmain.c line 3869
  • #9 g_application_run
    at gapplication.c line 2290
  • #10 main
    at src/main.c line 63 






Comment 1


Christian Hergert





          2015-01-27 15:49:11 UTC
        



Makes sense. The full text index can't support non-ascii (which is mostly fine for filenames, in practice). I'll just remove non-ascii characters from the search query.

Making a fuzzy index that uses gunichar will really bloat the index, but not out of the question.






Comment 2


Christian Hergert





          2015-01-27 16:30:19 UTC
        



Created attachment 295551 [details] [review]
git: ignore non-ascii characters when searching fulltext index

The fulltext index only supports ascii currently, so drop non-ascii
characters before looking things up.






Comment 3


Christian Hergert





          2015-01-27 16:30:36 UTC
        



Attachment 295551 [details] pushed as 2fe3612 - git: ignore non-ascii characters when searching fulltext index