After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743562 - Document signature support
Document signature support
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: documentation
master
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2015-01-26 23:17 UTC by Jim Nelson
Modified: 2015-01-29 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Document HTML signatures (1.94 KB, patch)
2015-01-27 16:53 UTC, Robert Schroll
none Details | Review
Document HTML signatures (1.89 KB, patch)
2015-01-28 05:45 UTC, Robert Schroll
committed Details | Review

Description Jim Nelson 2015-01-26 23:17:00 UTC
We need to add to the documentation an explanation about adding a signature to the account, as well as how HTML signatures work when those land (bug #738895).  This can go in "Accounts".

There should be a note in "Write a message" that directs the user to look in "Accounts" for more information about automatically adding a signature to messages.
Comment 1 Robert Schroll 2015-01-27 16:53:28 UTC
Created attachment 295554 [details] [review]
Document HTML signatures

I tried to avoid too many details about the escaping, to avoid scaring 
people who don't need to worry about it.  But I'm not sure that this is 
the right balance.
Comment 2 Jim Nelson 2015-01-27 20:54:09 UTC
Yeah, let's assume people who want to use HTML signatures know what they're doing.  It's enough to mention HTML is supported.

This looks good to me.  Something's not quite right about "Coding line breaks and hard spaces is not required." ... How about:

    You may use HTML tags to style the text.  (You don't need to use HTML or hard spaces, however.)

Something like that.  (By hard spaces, you mean nonbreaking spaces, correct?)  This isn't vital, just something I tripped on when I was reading it.

The positions of the buttons may need to be reworded, depending on how the final patch lands.
Comment 3 Robert Schroll 2015-01-28 05:45:30 UTC
Created attachment 295614 [details] [review]
Document HTML signatures

After further thought, I don't think we need that sentence at all.  As 
people go to add style to their signatures, they aren't going think, 
"Oh, now that I'm writing HTML, I have to put line breaks in 
explicitly."  They're just going to add whatever tag they need and hit 
preview.  Since we handle the whitespace for them, they're not going to 
even notice that something special is happening.

My only worry is that this behavior is a bit different that in the 
.signature file, but I don't think people that use this will be playing 
with the UI editor.
Comment 4 Jim Nelson 2015-01-29 22:03:19 UTC
Review of attachment 295614 [details] [review]:

That's fine.  Commit!
Comment 5 Robert Schroll 2015-01-29 22:28:32 UTC
Attachment 295614 [details] pushed as a624f29 - Document HTML signatures