GNOME Bugzilla – Bug 743518
qtdemux: dead code while calculating segment base ?
Last modified: 2015-01-28 19:19:48 UTC
While investigating bug 743363, I read qtdemux segment handling and I found something strange in it.
segment.base can be calculated twice in this code and the latter override the former:
Since I'm not familiar with qtdemux and segment, I don't know if it's just dead code or not.
Indeed that is dead code and the segment.base handling seems odd. Need to check what that dead code was meant to do.
Thanks for reporting, the override could be covered by the previous math if the 'stop' field had been set correctly a few lines above.
Author: Thiago Santos <email@example.com>
Date: Wed Jan 28 14:02:15 2015 -0300
qtdemux: simplify segment.base math
Remove a fix for heavily edited files added for fixing
https://bugzilla.gnome.org/show_bug.cgi?id=345830 to work
with seeks and proper gaps playback. The fix was replaced
for a more general solution that bases on using previous
segment's duration, just like it works for media segments