After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743498 - manifest: add gnome-calendar
manifest: add gnome-calendar
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on: 743540
Blocks:
 
 
Reported: 2015-01-25 17:38 UTC by Igor Gnatenko
Modified: 2015-01-26 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
manifest: add gnome-calendar (770 bytes, patch)
2015-01-25 17:39 UTC, Igor Gnatenko
none Details | Review
manifest: sync libical with upstream (1.19 KB, patch)
2015-01-26 12:16 UTC, Igor Gnatenko
none Details | Review
manifest: add gnome-calendar (784 bytes, patch)
2015-01-26 15:08 UTC, Vadim Rutkovsky
none Details | Review
manifest: use libical from github with configure patch (3.86 KB, patch)
2015-01-26 15:09 UTC, Vadim Rutkovsky
none Details | Review

Description Igor Gnatenko 2015-01-25 17:38:57 UTC
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 1 Igor Gnatenko 2015-01-25 17:39:01 UTC
Created attachment 295389 [details] [review]
manifest: add gnome-calendar
Comment 2 Vadim Rutkovsky 2015-01-26 11:55:28 UTC
This fails to build locally (see bug 1178069)

gcal-event-widget.o: In function `gcal_event_widget_is_multiday':
/ostbuild/source/gnome-calendar/_build/src/../../src/gcal-event-widget.c:1029: undefined reference to `icaltime_days_in_year'
collect2: error: ld returned 1 exit status

Apparently gnome-calendar requires libical 1.x actually, so we'll have to either update libical tarball or build it from git.
Comment 3 Igor Gnatenko 2015-01-26 12:09:45 UTC
(In reply to comment #2)
> This fails to build locally (see bug 1178069)
> 
> gcal-event-widget.o: In function `gcal_event_widget_is_multiday':
> /ostbuild/source/gnome-calendar/_build/src/../../src/gcal-event-widget.c:1029:
> undefined reference to `icaltime_days_in_year'
> collect2: error: ld returned 1 exit status
> 
> Apparently gnome-calendar requires libical 1.x actually, so we'll have to
> either update libical tarball or build it from git.

it has been fixed in fedora 21 and in fedora 22 some days ago.
Comment 4 Igor Gnatenko 2015-01-26 12:16:53 UTC
Created attachment 295443 [details] [review]
manifest: sync libical with upstream

Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 5 Vadim Rutkovsky 2015-01-26 12:24:39 UTC
(In reply to comment #4)
> Created an attachment (id=295443) [details] [review]
> manifest: sync libical with upstream
> 
> Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>

This also needs a cmake build patch and apparently some fixes:

Building CXX object src/libical/CMakeFiles/ical_cxx-static.dir/icalparameter_cxx.cpp.o
[  5%] In file included from /ostbuild/source/libical/src/libicalss/icalspanlist_cxx.cpp:21:0:
/ostbuild/source/libical/src/libicalss/icalspanlist_cxx.h:25:26: fatal error: libical/ical.h: No such file or directory
 #include <libical/ical.h>
                          ^
compilation terminated.
src/libicalss/CMakeFiles/icalss_cxx-static.dir/build.make:54: recipe for target 'src/libicalss/CMakeFiles/icalss_cxx-static.dir/icalspanlist_cxx.cpp.o' failed
make[2]: *** [src/libicalss/CMakeFiles/icalss_cxx-static.dir/icalspanlist_cxx.cpp.o] Error 1
CMakeFiles/Makefile2:498: recipe for target 'src/libicalss/CMakeFiles/icalss_cxx-static.dir/all' failed
make[1]: *** [src/libicalss/CMakeFiles/icalss_cxx-static.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  6%] [  7%] Generating icalderivedproperty.h
Building CXX object src/libical/CMakeFiles/ical_cxx-static.dir/icalproperty_cxx.cpp.o
[  7%] In file included from /ostbuild/source/libical/src/libical/icalparameter_cxx.cpp:21:0:
/ostbuild/source/libical/src/libical/icalparameter_cxx.h:24:26: fatal error: libical/ical.h: No such file or directory
 #include <libical/ical.h>
                          ^
compilation terminated.
src/libical/CMakeFiles/ical_cxx-static.dir/build.make:54: recipe for target 'src/libical/CMakeFiles/ical_cxx-static.dir/icalparameter_cxx.cpp.o' failed
make[2]: *** [src/libical/CMakeFiles/ical_cxx-static.dir/icalparameter_cxx.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Generating icalderivedproperty.h
[  7%] Building CXX object src/libical/CMakeFiles/ical_cxx-static.dir/icalvalue_cxx.cpp.o
Generating icalderivedparameter.h
In file included from /ostbuild/source/libical/src/libical/icalproperty_cxx.cpp:21:0:
/ostbuild/source/libical/src/libical/icalproperty_cxx.h:24:26: fatal error: libical/ical.h: No such file or directory
 #include <libical/ical.h>
                          ^
[  8%] compilation terminated.
src/libical/CMakeFiles/ical_cxx-static.dir/build.make:77: recipe for target 'src/libical/CMakeFiles/ical_cxx-static.dir/icalproperty_cxx.cpp.o' failed
make[2]: *** [src/libical/CMakeFiles/ical_cxx-static.dir/icalproperty_cxx.cpp.o] Error 1
[  9%] In file included from /ostbuild/source/libical/src/libical/icalvalue_cxx.cpp:23:0:
/ostbuild/source/libical/src/libical/icalvalue_cxx.h:22:26: fatal error: libical/ical.h: No such file or directory
 #include <libical/ical.h>
                          ^
compilation terminated.
src/libical/CMakeFiles/ical_cxx-static.dir/build.make:100: recipe for target 'src/libical/CMakeFiles/ical_cxx-static.dir/icalvalue_cxx.cpp.o' failed
make[2]: *** [src/libical/CMakeFiles/ical_cxx-static.dir/icalvalue_cxx.cpp.o] Error 1
CMakeFiles/Makefile2:302: recipe for target 'src/libical/CMakeFiles/ical_cxx-static.dir/all' failed
make[1]: *** [src/libical/CMakeFiles/ical_cxx-static.dir/all] Error 2
Generating icalderivedparameter.c
Comment 6 Vadim Rutkovsky 2015-01-26 15:08:24 UTC
Created attachment 295462 [details] [review]
manifest: add gnome-calendar
Comment 7 Vadim Rutkovsky 2015-01-26 15:09:07 UTC
Created attachment 295463 [details] [review]
manifest: use libical from github with configure patch
Comment 8 Vadim Rutkovsky 2015-01-26 15:09:33 UTC
Now we're blocked on bug 743540: srcdir != builddir issue in gnome-calendar
Comment 9 Vadim Rutkovsky 2015-01-26 15:41:03 UTC
Thanks, pushed