After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743467 - [4.4] Editing some saved queries does not work because 'query_format' URL parameter points to 'specific' instead of 'advanced'
[4.4] Editing some saved queries does not work because 'query_format' URL par...
Status: RESOLVED FIXED
Product: bugzilla.gnome.org
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Bugzilla Maintainers
Bugzilla Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-25 09:08 UTC by Robert Roth
Modified: 2015-02-10 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Robert Roth 2015-01-25 09:08:55 UTC
I (user evfool at yahoo.com) have a search (named openbugs-ordered) which can not be edited using the "Edit Search" link, as (unlike for other searches) that link gets me to the Simple Search page, and not the Advanced Search with the current settings prefilled.

Feel free to ask any further information.
Comment 1 André Klapper 2015-01-26 03:35:56 UTC
Is that on https://bugzilla-test.gnome.org/userprefs.cgi?tab=saved-searches ? 

Could you share that search with some group (e.g. admins) if it's not too secret stuff?
Comment 2 Robert Roth 2015-01-26 06:35:56 UTC
No, I didn't try it that way. On the bottom of bugzilla pages I have shortcuts to my searches (bugzilla adds one for each saved search). Clicking any of them brings me to the search results, with some additional options for that specific search after the search results: 
CSV | Feed | iCalendar | Change Columns | Change Several Bugs at Once | 	Edit Search 	| Forget Search 'openbugs-ordered'

The edit search link from this row brings me to the simple search page, so I can't edit that search. (I've also tried from saved-searches now that you mentioned, that doesn't work either)

I have shared that search with "developers", as I have no "admins" group available to share with.
Comment 3 André Klapper 2015-01-26 22:24:53 UTC
1) went to https://bugzilla-test.gnome.org/userprefs.cgi?tab=saved-searches
2) click "Run" for "openbugs-ordered" shared by bug reporter
3) found 58 tickets
4) scrolled down to "Edit Search"
5) indeed ended up on Simple Search page for this URL:

https://bugzilla-test.gnome.org/query.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=NEEDINFO&product=system-monitor&query_format=specific&known_name=openbugs-ordered

URL includes query_format=specific but should be query_format=advanced to work as expected.
Comment 4 André Klapper 2015-02-10 14:46:34 UTC
==== Reason ====

According to https://bugzilla.mozilla.org/show_bug.cgi?id=252295 from 2004 this should have been handled by http://bzr.mozilla.org/bugzilla/4.4/revision/2795 and that change is still included in 4.4. Don't know why this does not work.

==== Scope ====

Going to https://bugzilla.gnome.org/userprefs.cgi?tab=saved-searches and looking at its source code, there are only 3 shared queries affected by this. Don't know how many unshared ones are affected.

==== Workaround for affected users ====

Run the query, manually replace the offending parameter, and save that query again.

==== Finding affected queries for someone with DB access (not me) and potentially fixing them ====

SELECT query FROM namedqueries WHERE query LIKE "%query_format=specific%";
   ...and replacing/updating "specific" by "advanced".
Comment 5 Olav Vitters 2015-02-10 15:20:06 UTC
I ran the following on the database:
UPDATE namedqueries SET query = replace(query, 'query_format=specific', 'query_format=advanced') WHERE query LIKE "%query_format=specific%";