After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743433 - Avoid detaching a detached composer
Avoid detaching a detached composer
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
unspecified
Other All
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-24 04:18 UTC by Robert Schroll
Modified: 2015-01-27 02:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid detaching a detached composer (898 bytes, patch)
2015-01-24 04:18 UTC, Robert Schroll 		committed Details | Review

Description Robert Schroll 2015-01-24 04:18:31 UTC 
Although we hide the detach button when the composer is detached, the 
accelerator is still active.  Hitting it causes weirdness.  Rather than 
trying to disable the accelerator, we just keep it from doing anything 
when the composer is already detached.
Comment 1 Robert Schroll 2015-01-24 04:18:32 UTC 
Created attachment 295312 [details] [review]
Avoid detaching a detached composer
Comment 2 Jim Nelson 2015-01-26 22:17:44 UTC 
Review of attachment 295312 [details] [review]:

Commit!
Comment 3 Robert Schroll 2015-01-27 02:39:38 UTC 
Attachment 295312 [details] pushed as 28a489c - Avoid detaching a detached composer