GNOME Bugzilla – Bug 743403
Add new roles for math content
Last modified: 2015-01-26 13:33:09 UTC
Created attachment 295277 [details] [review] Proposed patch New roles for fractions, roots, subscripts, and superscripts were added to ATK (see bug 742806). We need them in AT-SPI2 now. Patch attached. Related aside: Seems none of us has been updating ATSPI_ROLE_COUNT. I've done so now. But do we really need the code in atspi_accessible_get_role_name() that uses it?
Review of attachment 295277 [details] [review]: Looks good. Just an off-topic comment. ::: atspi/atspi-constants.h @@ +1319,3 @@ * One higher than the highest valid value of #AtspiRole. */ +#define ATSPI_ROLE_COUNT (121+1) This has been outdated for a while (so the reason this patch sets it to 121, coming from 90). Not sure why it is needed if we have already ATSPI-ROLE_LAST_DEFINED. This is just an off-topic comment saying that this constant should be revisited (to not forget it). But shouldn't hold this patch.
(In reply to comment #1) > Review of attachment 295277 [details] [review]: > > Looks good. Just an off-topic comment. > > ::: atspi/atspi-constants.h > @@ +1319,3 @@ > * One higher than the highest valid value of #AtspiRole. > */ > +#define ATSPI_ROLE_COUNT (121+1) > > This has been outdated for a while (so the reason this patch sets it to 121, > coming from 90). Not sure why it is needed if we have already > ATSPI-ROLE_LAST_DEFINED. > > This is just an off-topic comment saying that this constant should be revisited > (to not forget it). But shouldn't hold this patch. Bug 743535 opened so we don't forget it.
Comment on attachment 295277 [details] [review] Proposed patch https://git.gnome.org/browse/at-spi2-core/commit/?id=12550e53