Created attachment 295272 [details] [review]
build: add compile option to disable building of Wi-Fi plugin

Before, the Wi-Fi plugin was always build. Users who didn't want
to use it would simply drop "libnm-device-plugin-wifi.so".

Add a compile time option to disable needlessly building the plugin.

If you're disabling WiFi, then there's no reason to run the configure-time checks for:

1) WEXT
2) linux/nl80211.h
3) HAVE_NL80211_CRITICAL_PROTOCOL_CMDS

Created attachment 295297 [details] [review]
build: add compile option to disable building of Wi-Fi plugin

Before, the Wi-Fi plugin was always build. Users who didn't want
to use it would simply drop "libnm-device-plugin-wifi.so".

Add a compile time option to disable needlessly building the plugin.

How about --enable-device-wifi; someone is eventually going to request the ability to not build wwan and bluetooth too, and we might as well have consistent naming for all of them.

Maybe even --enable-device-FOO=[yes|no|plugin] for extra sexiness...

(In reply to comment #4)
> How about --enable-device-wifi; someone is eventually going to request the
> ability to not build wwan and bluetooth too, and we might as well have
> consistent naming for all of them.
> 
> Maybe even --enable-device-FOO=[yes|no|plugin] for extra sexiness...

all the compile options are completely inconsistent. Would be a great to clean this up.

But regarding --enable-wifi, I feel that is correct. There should be only one major configure option to turn on/off Wi-Fi support. FWIW, it matches --enable-wimax.

Yeah I think --enable-wifi is OK for now, we can do a larger cleanup at some point and synchronize to --enable-device-FOO=XXX.

Rest looks OK to me.

merged: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=5439fbd77cd245b0a69cede67280767f6ffdc996

Thanks!!

Fastest responce I've ever seen!

I'll ensure to merge this in Gentoo.