After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743384 - A11y: Add Room/ Selection Mode Buttons should have Accessilble ATK names
A11y: Add Room/ Selection Mode Buttons should have Accessilble ATK names
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-22 23:30 UTC by chris
Modified: 2015-02-23 20:10 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14


Attachments
mainWindow: Improve accessible name of user-list button (1.16 KB, patch)
2015-02-23 20:06 UTC, Florian Müllner
committed Details | Review
ui: Set accessible name for join-menu button (1.23 KB, patch)
2015-02-23 20:07 UTC, Florian Müllner
committed Details | Review

Description chris 2015-01-22 23:30:18 UTC
The ButtonsAdd Room/ Selection Mode Buttons should have accessible Names. 

Reproduce
1. Enable Orca
2. Tab to Add Room / Selection mode Buttons via tab

result: orca is only able to announce "pushbutton"

Except: orca can read a lable for the Buttons like "Add Room" Button or "Selection Mode" Button
Comment 1 chris 2015-01-22 23:33:49 UTC
Maybe it would also good if the "userlist" Button does not only announce just an integer. it would be good if the accessible name is "12 Users" (if 12 users are in the current room) . this is more easy for blind people for orientation than just a numbner.
Comment 2 Florian Müllner 2015-02-23 20:06:24 UTC
Created attachment 297711 [details] [review]
mainWindow: Improve accessible name of user-list button

By only showing a single number, the user-list menu button clearly
errs on the side of space efficiency and visual cleanness rather
than discoverability. Those are not concerns for the accessible
name though, so we can use a less concise label there.
Comment 3 Florian Müllner 2015-02-23 20:07:04 UTC
Created attachment 297712 [details] [review]
ui: Set accessible name for join-menu button

The button uses only an image, which makes it "blank" to accessibility
tools like screen readers. Ouch. Set a (hopefully) descriptive name to
fix.
Comment 4 Florian Müllner 2015-02-23 20:10:40 UTC
Attachment 297711 [details] pushed as afa37a1 - mainWindow: Improve accessible name of user-list button
Attachment 297712 [details] pushed as 2a92e10 - ui: Set accessible name for join-menu button

(In reply to chris from comment #0)
> Expect: orca can read a lable for the Buttons like "Add Room" Button or
> "Selection Mode" Button

I went with "Join room" for the add button. The selection-mode button has been removed for 3.16.


(In reply to chris from comment #1)
> Maybe it would also good if the "userlist" Button does not only announce
> just an integer.

That makes a lot of sense, so I added that as well.