After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743364 - Revamp cairo-1.0.gir
Revamp cairo-1.0.gir
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-22 17:46 UTC by Nicola Fontana
Modified: 2017-05-09 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Cosmetic changes before real patches (2.91 KB, patch)
2015-01-22 17:46 UTC, Nicola Fontana 		committed Details | Review
CairoFontOptions is a GBoxed type (1.07 KB, patch)
2015-01-22 17:48 UTC, Nicola Fontana 		committed Details | Review
Correct wrong GLib type name for cairo_content_t (992 bytes, patch)
2015-01-22 17:48 UTC, Nicola Fontana 		committed Details | Review
Use proper GLib values for cairo_content_t (1.11 KB, patch)
2015-01-22 17:49 UTC, Nicola Fontana 		committed Details | Review
cairo_font_type_t is a GEnum (1.53 KB, patch)
2015-01-22 17:49 UTC, Nicola Fontana 		committed Details | Review
This is the main patch: include missing types from cairo (21.46 KB, patch)
2015-01-22 17:50 UTC, Nicola Fontana 		committed Details | Review

Description Nicola Fontana 2015-01-22 17:46:27 UTC 
Created attachment 295205 [details] [review]
Cosmetic changes before real patches

libcairo-gobject wraps in GObject style a lot of types that are not exported by the gir file.
Comment 1 Nicola Fontana 2015-01-22 17:48:11 UTC 
Created attachment 295206 [details] [review]
CairoFontOptions is a GBoxed type
Comment 2 Nicola Fontana 2015-01-22 17:48:44 UTC 
Created attachment 295207 [details] [review]
Correct wrong GLib type name for cairo_content_t
Comment 3 Nicola Fontana 2015-01-22 17:49:16 UTC 
Created attachment 295208 [details] [review]
Use proper GLib values for cairo_content_t
Comment 4 Nicola Fontana 2015-01-22 17:49:43 UTC 
Created attachment 295209 [details] [review]
cairo_font_type_t is a GEnum
Comment 5 Nicola Fontana 2015-01-22 17:50:20 UTC 
Created attachment 295210 [details] [review]
This is the main patch: include missing types from cairo
Comment 6 Nicola Fontana 2015-01-22 17:59:11 UTC 
Bug #686107 is somewhat related: it exports cairo_rectangle_t type.
Comment 7 André Klapper 2015-02-07 17:15:53 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]
Comment 8 Colin Walters 2015-02-13 20:43:50 UTC 
Hmm...how are you using this patch?  Is it with gjs?
Comment 9 Nicola Fontana 2015-02-13 23:24:12 UTC 
(In reply to Colin Walters from comment #8)
> Hmm...how are you using this patch?  Is it with gjs?

No, I'm using dynamic Lua bindings: https://github.com/pavouk/lgi

I have exported in the public API of my library a couple of functions that require cairo_surface_type_t, so fo my own purposes I just need that type.

I took the time to add also the other missing types though.
Comment 10 Nicola Fontana 2016-10-02 07:54:55 UTC 
I'll desperately need the above patches in the near future.

If it could help in speeding up, I can rebase and/or squash the above commits. Or if you prefer I can request a git account to have write access to the repository and do it by myself.
Comment 11 Emmanuele Bassi (:ebassi) 2017-05-04 21:22:35 UTC 
Review of attachment 295205 [details] [review]:

Ok
Comment 12 Emmanuele Bassi (:ebassi) 2017-05-04 21:23:28 UTC 
Review of attachment 295206 [details] [review]:

Okay.
Comment 13 Emmanuele Bassi (:ebassi) 2017-05-04 21:23:43 UTC 
Review of attachment 295207 [details] [review]:

Okay.
Comment 14 Emmanuele Bassi (:ebassi) 2017-05-04 21:24:01 UTC 
Review of attachment 295208 [details] [review]:

Okay.
Comment 15 Emmanuele Bassi (:ebassi) 2017-05-04 21:24:17 UTC 
Review of attachment 295209 [details] [review]:

Okay.
Comment 16 Emmanuele Bassi (:ebassi) 2017-05-04 21:24:59 UTC 
Review of attachment 295210 [details] [review]:

Okay.
Comment 17 Emmanuele Bassi (:ebassi) 2017-05-09 15:22:12 UTC 
Attachment 295206 [details] pushed as b7a8613 - CairoFontOptions is a GBoxed type
Attachment 295207 [details] pushed as deb946c - Correct wrong GLib type name for cairo_content_t
Attachment 295208 [details] pushed as 14dcadb - Use proper GLib values for cairo_content_t
Attachment 295209 [details] pushed as 08a817c - cairo_font_type_t is a GEnum