After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743360 - More cleanups
More cleanups
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-01-22 16:19 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2017-11-20 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
client: use G_DEFINE_TYPE_WITH_PRIVATE (2.36 KB, patch)
2015-01-22 16:19 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review
client: coding style cleanup (58.64 KB, patch)
2015-01-22 16:51 UTC, Ignacio Casal Quinteiro (nacho) 		reviewed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2015-01-22 16:19:11 UTC 
patches coming
Comment 1 Ignacio Casal Quinteiro (nacho) 2015-01-22 16:19:17 UTC 
Created attachment 295196 [details] [review]
client: use G_DEFINE_TYPE_WITH_PRIVATE
Comment 2 Ignacio Casal Quinteiro (nacho) 2015-01-22 16:51:06 UTC 
Created attachment 295200 [details] [review]
client: coding style cleanup

This puts some consistency in the document by correctly using
align vs indentation and by putting some proper spaces before
the (
Comment 3 Bastien Nocera 2015-01-24 14:01:15 UTC 
Review of attachment 295196 [details] [review]:

Sure.
Comment 4 Bastien Nocera 2015-01-24 14:02:18 UTC 
Review of attachment 295200 [details] [review]:

I'm hoping this is the result of running an indentation script. In which case, could you mention the exact command used in the commit message?
Comment 5 Bastien Nocera 2015-07-29 12:28:34 UTC 
Comment on attachment 295196 [details] [review]
client: use G_DEFINE_TYPE_WITH_PRIVATE

Attachment 295196 [details] pushed as 27fec02 - client: use G_DEFINE_TYPE_WITH_PRIVATE
Comment 6 Bastien Nocera 2016-01-04 12:03:17 UTC 
Waiting on an answer for comment 4.
Comment 7 Bastien Nocera 2017-11-20 14:37:02 UTC 
Marking as FIXED for the first patch. We'll do without reindentation.