After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743357 - Restore cursor breaks searching
Restore cursor breaks searching
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-22 15:51 UTC by Carlos Soriano
Modified: 2015-01-23 08:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
editor: allow clearing saved cursor position (2.57 KB, patch)
2015-01-22 22:02 UTC, Christian Hergert 		committed Details | Review
editor: reset saved cursor position when navigating search results (1.17 KB, patch)
2015-01-22 22:02 UTC, Christian Hergert 		committed Details | Review

Description Carlos Soriano 2015-01-22 15:51:58 UTC 
Commit ac953b00a86cd6be82ef297cbc3972113de7175e save the cursor saved when going out of focus and restore it again when focus is gain again. But for searching it's interesting to actually preserve the cursor the search is doing.

Not sure the best solution for this.
Comment 1 Christian Hergert 2015-01-22 22:02:24 UTC 
Created attachment 295220 [details] [review]
editor: allow clearing saved cursor position

Calling this will prevent jumping back to the previous position.
Comment 2 Christian Hergert 2015-01-22 22:02:28 UTC 
Created attachment 295221 [details] [review]
editor: reset saved cursor position when navigating search results
Comment 3 Christian Hergert 2015-01-22 22:02:48 UTC 
Should be fixed, thanks!

Attachment 295220 [details] pushed as 77c0c1d - editor: allow clearing saved cursor position
Attachment 295221 [details] pushed as 0faeb61 - editor: reset saved cursor position when navigating search results
Comment 4 Carlos Soriano 2015-01-23 08:44:10 UTC 
didn't find that part of the code to do a patch, thanks!