GNOME Bugzilla – Bug 743317
Year view should have visual clues of days with events
Last modified: 2017-04-17 18:20:40 UTC
Actually, every single day from year view is displayed the same. We should highlight days with events from those without events. Some suggestions: 1. Draw a circle around days with events 2. Bold the number of the day with events 3. Colorize the number of the day with event Could we have some input from the design team?
I sketched various possibilities, and I think having the year view as a huge navigator works best, when you start adding visual hints for events on days (I tried with colored dots, circles, lines) you get so much noise it gets painfull to use. My idea of the year view is mostly to have an overview of the whole year for figuring out things like which week day is a certain date or for week numbers. As a bonus it provides a quicker way to insert long events spanning different months. For dealing with events I think the month view is what should be used, I see no benefit in adding all the month view info to the year view.
Marking this bug as INVALID.
Reopening since a shared look and behaviour with shell calendar would be nice. In the past I tried having colored dots to indicate from which calendar the event come from which resulted in a lot of noise, I think just showing there are events is enough, so adding a dimmed dot always the same color, as in shell calendar, would do.
Created attachment 319619 [details] [review] year-view: Added visual clue for days with events Year view didn't have hints for days with events and this feature was requested to be added to gnome-calendar. This is an old request but in the past gnome-design team though it would be better to keep the layout simple without hints for days with events. Now with the changes in gnome-shell calendar and in order to keep them in sync, this feature was added to gnome-calendar. In order to implement this code we had to add a few css styles and a code to add a small circle below everyday with events. Although gnome-shell calendar uses an svg image with a 3x3 dot, we chose to use a pango function to draw the dot.
Comment on attachment 319619 [details] [review] year-view: Added visual clue for days with events Doesn't apply cleanly to master.
Created attachment 319876 [details] [review] year-view: Added visual clue for days with events Year view didn't have hints for days with events and this feature was requested to be added to gnome-calendar. This is an old request but in the past gnome-design team though it would be better to keep the layout simple without hints for days with events. Now with the changes in gnome-shell calendar and in order to keep them in sync, this feature was added to gnome-calendar. In order to implement this code we had to add a few css styles and a code to add a small circle below everyday with events. Although gnome-shell calendar uses an svg image with a 3x3 dot, we chose to use a pango function to draw the dot.
Review of attachment 319876 [details] [review]: ::: src/gcal-year-view.c @@ +745,3 @@ + box_side * (column + 0.5 + year_view->k) + x + sw * box_padding_start - year_view->k * 3, + box_side * (row + 1) + y + box_padding_top + layout_height + 2.0, + 3.0, 3.0); I think it's better to put this in a #define right below the enums, instead of hardcoding the values here.
Created attachment 320048 [details] [review] year-view: Added visual clue for days with events Year view didn't have hints for days with events and this feature was requested to be added to gnome-calendar. This is an old request but in the past gnome-design team though it would be better to keep the layout simple without hints for days with events. Now with the changes in gnome-shell calendar and in order to keep them in sync, this feature was added to gnome-calendar. In order to implement this code we had to add a few css styles and a code to add a small circle below everyday with events. Although gnome-shell calendar uses an svg image with a 3x3 dot, we chose to use a pango function to draw the dot.
Thanks for working on it! Attachment 320048 [details] pushed as e8c75ce - year-view: Added visual clue for days with events