After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743316 - Add libsoup as dependency to tmdb plugin in configure.ac
Add libsoup as dependency to tmdb plugin in configure.ac
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-21 20:51 UTC by Guilhèm Bonnefille
Modified: 2015-02-17 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A small fix to check libsoup when doing tmdb dependencies checking (1.13 KB, patch)
2015-01-21 20:55 UTC, Guilhèm Bonnefille 		none Details | Review
A small fix to check libsoup when doing tmdb dependencies checking (1.23 KB, patch)
2015-01-21 22:09 UTC, Guilhèm Bonnefille 		accepted-commit_now Details | Review
tmdb: Fix tmdb building even if libsoup isn't available (1.45 KB, patch)
2015-02-17 17:11 UTC, Bastien Nocera 		committed Details | Review

Description Guilhèm Bonnefille 2015-01-21 20:51:32 UTC 
When libsoup-dev is not installed, the build failed at compilation time in tmdb plugin.

It seems that such type of error should be catched by configure in order to provide a more explicit error. For example, it's done for dLeyna and OpenSubtitles plugins.
Comment 1 Guilhèm Bonnefille 2015-01-21 20:55:51 UTC 
Created attachment 295132 [details] [review]
A small fix to check libsoup when doing tmdb dependencies checking
Comment 2 Guilhèm Bonnefille 2015-01-21 22:09:44 UTC 
Created attachment 295133 [details] [review]
A small fix to check libsoup when doing tmdb dependencies checking

Oops! Previous patch was an old version.
Comment 3 Bastien Nocera 2015-01-21 22:10:47 UTC 
Review of attachment 295133 [details] [review]:

Looks good.
Comment 4 Bastien Nocera 2015-02-17 17:11:33 UTC 
Created attachment 297037 [details] [review]
tmdb: Fix tmdb building even if libsoup isn't available

Disable the tmdb plugin if libsoup isn't available.
Comment 5 Bastien Nocera 2015-02-17 17:12:40 UTC 
Attachment 297037 [details] pushed as 1101c67 - tmdb: Fix tmdb building even if libsoup isn't available