After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743264 - Add play icon to tabs that are playing audio/video
Add play icon to tabs that are playing audio/video
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-20 19:28 UTC by Bastien Nocera
Modified: 2015-02-03 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show a speaker icon in tabs that are playing audio (4.27 KB, patch)
2015-01-22 13:19 UTC, Carlos Garcia Campos
committed Details | Review
Screenshot (342.46 KB, image/png)
2015-01-22 13:19 UTC, Carlos Garcia Campos
  Details

Description Bastien Nocera 2015-01-20 19:28:34 UTC
New in WebKitGTK+ 2.7.4 is:
"Add is-playing-audio property to WebKitWebView."

This should allow us to add a play icon to tabs easily.
Comment 1 Carlos Garcia Campos 2015-01-21 07:47:44 UTC
Yes, that was the idea. The problem is where to add it, to the tab? at the left after the favicon or at the right before the close button? There isn't many space in tabs (when you have a lot open which is very common), but there's plenty of free space in the toolbar/headerbar.
Comment 2 Michael Catanzaro 2015-01-21 13:34:27 UTC
The point is to put it on the tab so that you can tell which tab(s) is playing audio. I was thinking we would just replace the favicon with the play icon in this case.
Comment 3 Carlos Garcia Campos 2015-01-22 13:19:26 UTC
Created attachment 295165 [details] [review]
Show a speaker icon in tabs that are playing audio
Comment 4 Carlos Garcia Campos 2015-01-22 13:19:49 UTC
Created attachment 295166 [details]
Screenshot
Comment 5 Bastien Nocera 2015-01-22 13:31:00 UTC
I'd replace the favicon instead, as it's more relevant that it's playing something than which website it is. It also avoids wasting more space in width-constrained usage.
Comment 6 Carlos Garcia Campos 2015-01-22 13:36:53 UTC
(In reply to comment #5)
> I'd replace the favicon instead, as it's more relevant that it's playing
> something than which website it is. It also avoids wasting more space in
> width-constrained usage.

I thought about it, but tried this way to see how it looked, because it looks nice keeping the favicon so I left it this way. If it becomes a problem of space eventually we could try replacing the favicon.
Comment 7 Carlos Garcia Campos 2015-02-03 14:26:17 UTC
I've pushed the patch as it is for now, feel free to update it to replace the favicon if it's really a problem for tab space.