After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743255 - man page generation does not check for required stylesheets
man page generation does not check for required stylesheets
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-20 16:34 UTC by David King
Modified: 2015-01-23 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix the incorrect variable (1.78 KB, patch)
2015-01-20 16:35 UTC, David King 		committed Details | Review
check for the necessary stylesheets and XML catalog (4.59 KB, patch)
2015-01-20 16:36 UTC, David King 		committed Details | Review

Description David King 2015-01-20 16:34:34 UTC 
Checking for the presence of xsltproc is not enough, and the XSL stylesheets required for creating the man page should be checked as well. Additionally, a variable used to check whether man pages should be enabled was never set.
Comment 1 David King 2015-01-20 16:35:56 UTC 
Created attachment 295019 [details] [review]
fix the incorrect variable
Comment 2 David King 2015-01-20 16:36:18 UTC 
Created attachment 295020 [details] [review]
check for the necessary stylesheets and XML catalog
Comment 3 Erick Perez Castellanos 2015-01-23 21:40:13 UTC 
(In reply to comment #1)
> Created an attachment (id=295019) [details] [review]
> fix the incorrect variable

I've had your patches on my pc for days, trying to find the time to do the testing. Sorry
Comment 4 David King 2015-01-23 21:48:35 UTC 
No problem! Take your time, it is not urgent.
Comment 5 David King 2015-01-23 21:54:31 UTC 
Review of attachment 295020 [details] [review]:

Pushed to master as fa4f2c798bdf6d7de95ef5f1239b5951edfff60b.
Comment 6 David King 2015-01-23 21:54:53 UTC 
Review of attachment 295019 [details] [review]:

Pushed to master as 9498561cf61a4f6fa2f2a9b618307ef2198e11d1. Thanks!