GNOME Bugzilla – Bug 743247
provide consistent thumbnail style
Last modified: 2015-03-06 18:55:48 UTC
We currently have varying styles for thumbnails. Here's a little list of how I think we should style them: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/thumbnails.png I'm told we're going to have to deal with mixed views of portrait and landscape thumbnails. If this was Photos, I'd suggest going with square tiles as that gives the most pleasing grid and the occurence of portrait orientation isn't rare. For Videos I'd probably go with 4:3 aspect ratio to make the landscape thumbnails feel better.
I'd go for square tiles all ove the place, videos included, I'd probably fill the square with the video thumb tho, but you'll lose the landscape/portrait info. In case that's an important info I'd show the bands, but we don't need to make the proportions accourate, we can still cut away some part of the video to make it look nicer bands or not. Anyway I'd color the bands in black.
(In reply to comment #1) > I'd go for square tiles all ove the place, videos included, ... Like this perhaps? https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/thumbnails-square.png I'm not quite sure what rules you're thinking of for "smarter" letterboxing...
*** Bug 745577 has been marked as a duplicate of this bug. ***
I'll need to finish implementing this before 3.16 is out, as my attempts broke some things (see bug 745577).
Created attachment 298729 [details] [review] icon-helpers: Improve thumbnailing style Thumbnails are now square to avoid reflow when loading new items which might have mixed types of media (vertical videos, covers vs. horizontal TV/cinema videos). Mockup is at: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/thumbnails-square.png
Created attachment 298730 [details] [review] icon-helpers: Don't require a GApplication We won't need it in our test application.
Created attachment 298731 [details] [review] icon-helpers: Add guard in totem_grilo_get_icon() To avoid crashing when we use the API badly.
Created attachment 298732 [details] [review] icon-helpers: Add test application for thumbnail changes
Created attachment 298733 [details] [review] grilo: Load large Apple trailers covers The small ones are about 130 pixels wide, and our icons 256x256.
Created attachment 298738 [details] [review] icon-helpers: Add test application for thumbnail changes
Created attachment 298741 [details] [review] icon-helpers: Improve thumbnailing style Thumbnails are now square to avoid reflow when loading new items which might have mixed types of media (vertical videos, covers vs. horizontal TV/cinema videos). Mockup is at: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/thumbnails-square.png
Created attachment 298742 [details] [review] icon-helpers: Add test application for thumbnail changes
All pushed to master. Let me know whether you find any differences between the mockups and the implementation. Attachment 298730 [details] pushed as edd088b - icon-helpers: Don't require a GApplication Attachment 298731 [details] pushed as 5a789a8 - icon-helpers: Add guard in totem_grilo_get_icon() Attachment 298733 [details] pushed as 26519e2 - grilo: Load large Apple trailers covers Attachment 298741 [details] pushed as 58f1607 - icon-helpers: Improve thumbnailing style Attachment 298742 [details] pushed as 748c0aa - icon-helpers: Add test application for thumbnail changes