After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743231 - make crypto optional
make crypto optional
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-20 09:23 UTC by Christian Persch
Modified: 2015-01-20 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
optional encryption - ifdefs (3.47 KB, patch)
2015-01-20 14:31 UTC, Egmont Koblinger
none Details | Review

Description Christian Persch 2015-01-20 09:23:55 UTC
Since vte now depends on gnutls >= 3.2.0 but fedora 19 only has 3.1.x, and the vte code really does require 3.2.0, I now can't even build vte.

Should we add a --without-gnutls configure switch and corresponding #if out of the crypto code?
Comment 1 Egmont Koblinger 2015-01-20 09:56:26 UTC
I had a feeling someone was to ask for it anyway, perhaps when vte is used in an installer where they just don't want to have crypto stuff.  Or when a distro forces all file systems and swap to be encrypted there it doesn't make too much sense. Let's go for it.
Comment 2 Egmont Koblinger 2015-01-20 14:31:56 UTC
Created attachment 294998 [details] [review]
optional encryption - ifdefs

Here's the bits for the vtestream-file.h ifdefs.

Could you please add the autoconf bits and submit?  I loathe autoconf, and seems to me you have a lot more experience with that.
Comment 3 Christian Persch 2015-01-20 15:51:25 UTC
I added the configure bits. (Named the define WITH_GNUTLS, however.)
Comment 4 Egmont Koblinger 2015-01-20 16:03:00 UTC
Thanks. Submitted the rest.