After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743195 - uri: Add parsing unit test based on GNet
uri: Add parsing unit test based on GNet
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
Other All
: Normal blocker
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-01-19 18:27 UTC by Sebastian Dröge (slomo)
Modified: 2015-01-22 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

uri: Add paring unit test based on GNet (9.50 KB, patch)
2015-01-19 18:27 UTC, Sebastian Dröge (slomo)
none Details | Review
Fix parsing and amend tests to correct expected results. (20.05 KB, patch)
2015-01-21 14:18 UTC, David Waring
committed Details | Review

Description Sebastian Dröge (slomo) 2015-01-19 18:27:43 UTC
There are a few failing tests for now which have to be fixed before we can
release this API.
Comment 1 Sebastian Dröge (slomo) 2015-01-19 18:27:48 UTC
Created attachment 294908 [details] [review]
uri: Add paring unit test based on GNet

Plus some new URIs to parse.
Comment 2 Sebastian Dröge (slomo) 2015-01-19 18:30:46 UTC
This also includes a test for a case Marc Leeman reported on IRC today:
rtp://123.456.789.012:345?query (without a / to terminate authority).

Which would be equivalent to:

for the parser.
Comment 3 Marc Leeman 2015-01-20 08:22:51 UTC
(09:18:12 AM) den_erpel: slomo: started thinking about the uri
(09:18:18 AM) den_erpel: I probably have a fix
(09:18:53 AM) den_erpel: we need to look for '/' and '?'; if '?' if before '/', the eoa is the '?', otherwise the '/'
Comment 4 Sebastian Dröge (slomo) 2015-01-20 08:41:46 UTC
Note that the first unit test failure currently is that
> scheme://[ipv6address]/path
does not drop the brackets around the address when asking for the host.
Comment 5 David Waring 2015-01-20 13:40:50 UTC
I'm having a look at this.

Yes, the parsing code assumes that a path follows an authority part, that's easily modified to terminate the authority part at a query or fragment too, so scheme://user@host:123?query and scheme://user@host:123#fragment would also work.

The default was to leave the square brackets in the host string, I can change that to strip them. Although it's debatable how to handle "scheme://[01:23:45:67:89:ab:cd:ef:123/path" as the RFC says there must be a closing square bracket, and that the brackets only contain unreserved, sub-delim and ":". This means that the authority part would end at the "/". I'd say in that case it would be host="[01:23:45:67:89:ab:cd:ef", port=123 (since we're back to <host>:<port>) and path="/path" as the only sensible way to interpret this.

I'll work my way through the test cases and post a patch to fix any problems I find.
Comment 6 David Waring 2015-01-20 13:55:20 UTC
Review of attachment 294908 [details] [review]:

I found some discrepancies between the tested URI's and their expected output.

::: tests/check/gst/gsturi.c
@@ -167,0 +167,103 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ *
+ */
... 100 more ...

The previous 4 test cases all have a scheme but are looking for a NULL scheme entry in the output

@@ -167,0 +167,126 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ *
+ */
... 123 more ...

Paths after an authority must start with a single "/" according to RFC3986. So in this case the hostname is "hostname" with no port and a path of ":123path".

@@ -167,0 +167,139 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ *
+ */
... 136 more ...

Wouldn't the port be 23?

@@ -167,0 +167,144 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ *
+ */
... 141 more ...

This should probably cause a parsing error since [ is not allowed without a ] and [ is not allowed in the other host part forms in RFC3986.
Comment 7 David Waring 2015-01-21 14:18:25 UTC
Created attachment 295102 [details] [review]
Fix parsing and amend tests to correct expected results.

This should fix the URI parsing issues and corrects some of the expected test results from Sebastian's patch. It also adds some tests to check the string presentation of URI's, including that square brackets are added to IPv6 addresses on conversion to string to match the new stripping of brackets behaviour.

This patch includes Sebastian's patch too.
Comment 8 Sebastian Dröge (slomo) 2015-01-21 16:57:30 UTC
I think "scheme://hostname:123path?query#fragment" is a valid URI, nothing says that the path must start with a / if I'm not mistaken.
path-abempty, path-noscheme, path-rootless and path-empty can start with almost anything

The other changes you did look reasonable to me :) Thanks for working on this.
Comment 9 David Waring 2015-01-22 07:35:37 UTC
RFC 3986, Section 3, second paragraph
  "When authority is present, the path must
   either be empty or begin with a slash ("/") character. When
   authority is not present, the path cannot begin with two slash
   characters ("//")."

So if the authority part is present ("//" [userinfo "@"] host [":" port]), then the path must be absolute or not present at all. If there's no authority part then a path may start with almost any character.

Since host cannot contain ":" unless it is surrounded by square brackets, then I believe that means that "//hostname:123path" is not a valid authority part. If there's no authority part, the path cannot start with "//", so then the URI is invalid.
Comment 10 Sebastian Dröge (slomo) 2015-01-22 21:09:59 UTC
Ah, missed that part. Thanks :)

commit d20fa132c117240ad386a5a3b472dc629407b445
Author: David Waring <>
Date:   Wed Jan 21 14:10:02 2015 +0000

    uri: Fix new URI parsing tests based on GNet's

commit ab9b66e6becfdb944b2229a14e0ead7308a7bf92
Author: David Waring <>
Date:   Wed Jan 21 14:09:45 2015 +0000

    uri: Fix parsing issues
    Make host IPs in square brackets store only the IP, i.e. strip the brackets.
    Strip leading whitespace characters in URIs.
    Fail parsing when host part does not match any valid formats from RFC3986.

commit 0637703fe78a6be09166cc3bc392f5421c80055d
Author: Sebastian Dröge <>
Date:   Mon Jan 19 19:15:32 2015 +0100

    uri: Add parsing unit test based on GNet's
    Plus some new URIs to parse.