After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743192 - support for alsa compress API
support for alsa compress API
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-19 17:30 UTC by Qais Yousef
Modified: 2018-11-03 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
RFC patch that adds alsacsink plugin which supports ALSA Compress Offload API (14.48 KB, patch)
2015-03-24 15:31 UTC, Qais Yousef
none Details | Review
Add alsa compres offload sink component (17.20 KB, patch)
2015-07-22 10:01 UTC, Qais Yousef
none Details | Review

Description Qais Yousef 2015-01-19 17:30:31 UTC
As per the thread on gstreamer mailing list [1], I'm looking at adding support for alsa compress API. Any direction on what's the advised method of adding this support? To start up I'm wondering whether the support should be an extension of existing alsasink component or whether to add it as a separate component (which I think is the better option).

Thanks,
Qais

[1] http://gstreamer-devel.966125.n4.nabble.com/ALSA-Compress-Offload-support-td4670153.html
Comment 1 Qais Yousef 2015-03-24 15:31:05 UTC
Created attachment 300204 [details] [review]
RFC patch that adds alsacsink plugin which supports ALSA Compress Offload API

This is only an RFC patch to make sure I'm going correctly about this. I still need to do more work to finish this but it would be nice to have an early feedback.
Comment 2 Bastien Nocera 2015-04-29 14:32:15 UTC
The tiny compress library is at:
http://git.alsa-project.org/?p=tinycompress.git;a=summary
Comment 3 Qais Yousef 2015-04-29 14:39:32 UTC
I sent a patchset to convert it to proper autotools package

http://thread.gmane.org/gmane.linux.alsa.devel/135948/focus=135954
Comment 4 Qais Yousef 2015-07-22 10:01:02 UTC
Created attachment 307897 [details] [review]
Add alsa compres offload sink component

I didn't get any feedback on the RFC. Here's the final patch which works fine for me. It supports playing pcm, mp3, aac and flac formats. Compress offload supports more formats which can be added later.

Any comments/feedback would be much appreciated. It would be great to have this merged soon.
Comment 5 Qais Yousef 2015-09-07 13:04:21 UTC
I don't know how long it usually takes for reviews to happen. But I'm just pinging in case this slipped through :-)
Comment 6 Tim-Philipp Müller 2015-09-07 13:16:07 UTC
It's good to ping every now and then, things easily fall through the cracks. Currently we're frozen and in release mode though, trying to get 1.6 out the door, and new features will only be merged once 1.6 is out. I would recommend you ping again once 1.6 is out, if nothing happens in the mean time :)
Comment 7 Qais Yousef 2015-09-07 13:35:39 UTC
OK thanks a lot for the quick response, will do :)
Comment 8 Qais Yousef 2015-10-08 10:51:46 UTC
I hope it's a good time to ping now?
Comment 9 Tim Sheridan 2015-11-05 11:51:37 UTC
Adding myself to CC.

Qais is moving on from our Gstreamer work, and I'll be picking up anything left to do with this.
Comment 10 GStreamer system administrator 2018-11-03 11:34:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/155.