GNOME Bugzilla – Bug 743178
pulsesink: Free format_info in query_getcaps
Last modified: 2015-01-27 05:55:47 UTC
If we can not create probe stream in query_getcaps function, it will appear memory leakage from format info I think. Also, for code readability, it should be merged i think. The following patch prevent memory leakage in pulsesink.
Created attachment 294873 [details] [review] Free format_info in query_getcaps Free format_info in query_getcaps
Review of attachment 294873 [details] [review]: Nice find, just one remark on the code. Also, when submitting a new version please check previous gstreamer commit messages and follow the same style. Something like: pulseseink: [title of the commit] [description - multiple lines if needed] [bug url] ::: ext/pulse/pulsesink.c @@ +2170,1 @@ goto unlock; The code right after this also frees this object so it would be better to have the free happening before the if as it needs to be done for both branches.
thank you for your comment. I have modified source code following your comment. here is the modified source patch.
Created attachment 294937 [details] If we can not create probe stream in query_getcaps function, it will appear memory leakage.
Created attachment 294939 [details] [review] pulsesink: Free format_info in query_getcaps If we can not create probe stream in query_getcaps function, it will appear memory leakage from format info. The following patch prevent memory leakage in pulsesink. https://bugzilla.gnome.org/show_bug.cgi?id=743178
5
Pushed, thanks for the patch. For future patches, please commit your work in your local tree and use "git format-patch" to create the patch to attach here. I had to copy your commit message manually as git didn't recognize it in the format your attached. In master: commit bf10d33b9b95856aabbc12dfa7c5ede50a27b38c Author: Jimmy Ohn <yongjin.ohn@lge.com> Date: Tue Jan 20 00:32:00 2015 +0000 pulsesink: Free format_info in query_getcaps If we can not create probe stream in query_getcaps function, it will appear memory leakage from format info. The following patch prevent memory leakage in pulsesink. https://bugzilla.gnome.org/show_bug.cgi?id=743178 In 1.4: commit 56f5ae3f089e13b2593a52ec8fb22168dae96144 Author: Jimmy Ohn <yongjin.ohn@lge.com> Date: Tue Jan 20 00:32:00 2015 +0000 pulsesink: Free format_info in query_getcaps If we can not create probe stream in query_getcaps function, it will appear memory leakage from format info. The following patch prevent memory leakage in pulsesink. https://bugzilla.gnome.org/show_bug.cgi?id=743178
Oh.. I see. When I upload future patches, I will work in my local tree and upload it. thank you very much.:)