After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743162 - Wrong keybindings for save-all / save-as
Wrong keybindings for save-all / save-as
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-19 09:16 UTC by Paolo Borelli
Modified: 2015-01-19 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keybindings: more closely follow hig for keybindings (2.74 KB, patch)
2015-01-19 09:53 UTC, Christian Hergert
committed Details | Review

Description Paolo Borelli 2015-01-19 09:16:26 UTC
https://git.gnome.org/browse/gnome-builder/commit/?id=d716769b35acdc9d4ed60b2c7f8a51af2ee83301

Changed the keybindings for these actions but I do not think that's correct.

The HIG* suggests ctrl+shift+s for save as and ctrl+shift+L for save all


*) admittedly it was the old HIG I have not checked the new one, but since the new one is much more high-level than the old I still think the old one relevant for these details
Comment 1 Christian Hergert 2015-01-19 09:36:55 UTC
I'm okay with that. However, I do think we are going to vary from the HIG on keybindings eventually.

We'll need to update the move/split left/right keybindings too. We should probably change those to use arrows.
Comment 2 Christian Hergert 2015-01-19 09:53:15 UTC
Created attachment 294849 [details] [review]
keybindings: more closely follow hig for keybindings

I had to get creative here for moving left/right (since we needed
ctrl+shift+l for save-all). But i think this works pretty well.

ctrl+shift+{left,right} for spliting.
alt+shift+{left,right} for moving.
Comment 3 Christian Hergert 2015-01-19 09:53:31 UTC
Attachment 294849 [details] pushed as df4323d - keybindings: more closely follow hig for keybindings
Comment 4 Christian Hergert 2015-01-19 09:54:04 UTC
GNOME Shell keybindings made it a bit extra annoying, but these work (for now) :)