After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743126 - Take advantage of gtk_source_buffer_join_lines
Take advantage of gtk_source_buffer_join_lines
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-18 14:07 UTC by Paolo Borelli
Modified: 2015-01-18 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.67 KB, patch)
2015-01-18 14:08 UTC, Paolo Borelli 		committed Details | Review

Description Paolo Borelli 2015-01-18 14:07:59 UTC 
for the vim J command
Comment 1 Paolo Borelli 2015-01-18 14:08:26 UTC 
Created attachment 294781 [details] [review]
patch
Comment 2 Igor Gnatenko 2015-01-18 14:37:53 UTC 
Review of attachment 294781 [details] [review]:

Other looks good to me.

::: src/vim/gb-source-vim.c
@@ +1996,2 @@
   if (!has_selection)
+      gtk_text_iter_forward_line (&selection);

style: please use 2 spaces instead of 4
Comment 3 Igor Gnatenko 2015-01-18 14:42:57 UTC 
I've fixed style typo, added bug reference and pushed to master
Comment 4 Igor Gnatenko 2015-01-18 14:44:04 UTC 
https://git.gnome.org/browse/gnome-builder/commit/?id=4804c1eaeff7f5de20e7b28b1a4a6ce9aaf9cefd

Thanks for working in gtksourceview side and for patch!